GitHub Workflows security hardening #6814
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sashashura <[email protected]>
jinjingforever
approved these changes
Sep 6, 2022
Neilblaze
approved these changes
Sep 15, 2022
Contributor
Author
|
Ready to merge? |
Contributor
|
We need one more approval , @mattsoulanille could you please help review this PR.Thank you! |
mattsoulanille
approved these changes
Sep 23, 2022
Member
mattsoulanille
left a comment
mattsoulanille
left a comment
There was a problem hiding this comment.
LGTM. Thanks! We should also update deploy-benchmark-preview.yml, which runs on PRs and is therefore more dangerous.
Contributor
Author
It is triggered on |
dydavidkim
added a commit
to CodeSmithDSMLProjects/tfjs
that referenced
this pull request
Sep 26, 2022
Update deploy-benchmark-prod.yml (tensorflow#6814)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from
on: pull_requestfrom external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted.It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.
This change is