Run the next BrowserStack benchmark immediately instead of in batches #6717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, the benchmark script would start x benchmarks, wait for them all to complete, and then start the next x. This change makes it start new benchmarks immediately when prior benchmarks complete so that there are always x benchmarks running. This doesn't work across tests that require different karma configs (e.g. changing model / parameters), and all tests from one karma config must complete before tests with a different karma config can start.
mattsoulanille
force-pushed
the
promise_queue
branch
from
ed93a9e to
e5b2475
Compare
lina128
approved these changes
Aug 3, 2022
Collaborator
lina128
left a comment
lina128
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 1 of 1 approvals obtained (waiting on @Linchenn)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the benchmark script would start x benchmarks, wait for them all to complete, and then start the next x. This change makes it start new benchmarks immediately when prior benchmarks complete so that there are always x benchmarks running.
This doesn't work across tests that require different karma configs (e.g. changing model / parameters), and all tests from one karma config still must complete before tests with a different karma config can start.
To see the logs from the Cloud Build CI, please join either our discussion or announcement mailing list.
This change is