Skip to content

Conversation

@crowlKats
Copy link

@crowlKats crowlKats commented Jul 23, 2022

as per https://gpuweb.github.io/gpuweb/wgsl/#reserved-words, mod is a reserved keyword, which is causing the webgpu implementation of deno to error. seems chrome doesnt check for these keywords yet.


This change is Reviewable

Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@qjia7 qjia7 requested a review from gyagp July 25, 2022 01:14
Copy link

@gyagp gyagp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gyagp gyagp merged commit c5cf6f5 into tensorflow:master Jul 25, 2022
@crowlKats crowlKats deleted the mod_to_modulo branch July 25, 2022 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants