Skip to content

De-flake fromPixels test failure #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 5, 2022
Merged

De-flake fromPixels test failure #6626

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2723787
De-flake fromPixels test failure
hujiajie Aug 1, 2022
8faf11c
Merge branch 'master' into master
Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions tfjs-core/src/ops/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,16 +107,6 @@ function fromPixels_(
` or {data: Uint32Array, width: number, height: number}, ` +
`but was ${(pixels as {}).constructor.name}`);
}
if (isVideo) {
const HAVE_CURRENT_DATA_READY_STATE = 2;
if (isVideo &&
(pixels as HTMLVideoElement).readyState <
HAVE_CURRENT_DATA_READY_STATE) {
throw new Error(
'The video element has not loaded data yet. Please wait for ' +
'`loadeddata` event on the <video> element.');
}
}
// If the current backend has 'FromPixels' registered, it has a more
// efficient way of handling pixel uploads, so we call that.
const kernel = getKernel(FromPixels, ENGINE.backendName);
Expand Down
9 changes: 0 additions & 9 deletions tfjs-core/src/ops/from_pixels_test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,15 +233,6 @@ describeWithFlags('fromPixels', BROWSER_ENVS, () => {
document.body.removeChild(video);
}, 30_000 /* 30 seconds */);

it('fromPixels for HTMLVideoElement throws without loadeddata', async () => {
const video = document.createElement('video');
video.width = 1;
video.height = 1;
video.src = 'data:image/gif;base64' +
',R0lGODlhAQABAIAAAP///wAAACH5BAEAAAAALAAAAAABAAEAAAICRAEAOw==';
expect(() => tf.browser.fromPixels(video)).toThrowError();
});

it('throws when passed a primitive number', () => {
const msg = /pixels passed to tf.browser.fromPixels\(\) must be either/;
// tslint:disable-next-line:no-any
Expand Down