Skip to content

[webgpu] Fix access mode for storage address space #6607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2022
Merged

[webgpu] Fix access mode for storage address space #6607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0073ab7
[webgpu] Fix access mode for storage address space
haoyunfeix Jul 6, 2022
2c172ca
Change module-scope 'let' -> 'const'
haoyunfeix Jul 7, 2022
b662a5c
Merge branch 'master' into webgpu_fix_access_mode
haoyunfeix Jul 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tfjs-backend-webgpu/src/matmul_packed_webgpu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ export function makeMatMulVectorSource(
workGroupSize[1] === 1 && workGroupSize[2] === 1,
() => `A linear work group size is required. But got ${workGroupSize}.`);
return `
let TileSize = ${workGroupSize[0] * 4};
const TileSize = ${workGroupSize[0] * 4};
var<workgroup> mm_Asub : array<vec4<f32>, ${workGroupSize[0]}>;

${getMainHeaderString()}
Expand Down
4 changes: 2 additions & 2 deletions tfjs-backend-webgpu/src/webgpu_program.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ function makeShader(
outShapeStrides : vec2<i32>,
};

@group(0) @binding(0) var<storage, write> result: array<${
@group(0) @binding(0) var<storage, read_write> result: array<${
mapToWgslTypes(outputData.dtype, program.isVec4)}>;
@group(0) @binding(2) var<uniform> uniforms: Uniform;
`);
Expand Down Expand Up @@ -238,7 +238,7 @@ function makeShader(
`);
} else {
prefixSnippets.push(`
@group(0) @binding(0) var<storage, write> result: array<${
@group(0) @binding(0) var<storage, read_write> result: array<${
mapToWgslTypes(outputData.dtype, program.isVec4)}>;
`);
}
Expand Down