This repository was archived by the owner on Aug 15, 2019. It is now read-only.
Add browser.crypto: false to package.json #1821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding browser.crypto: false to package.json results in not including crypto and it's dependencies when using `browserify` and `parcel` as bundlers for an end application. Test used: I made a hello-world js application that depends on tfjs-core. Expected my bundle to be ~500kb, but I got 810kb. This fixed the issue
dsmilkov
added a commit
to tensorflow/tfjs-data
that referenced
this pull request
Jun 28, 2019
Adding `browser.crypto: false` to `package.json` results in not including crypto and it's dependencies when using `browserify` and `parcel` as bundlers for an end application. Test used: I made a hello-world js application that depends on tfjs-core and tfjs-data. Expected my bundle to be ~550kb, but I got 860kb. This fixed the issue. Analogous PR in tfjs-core: tensorflow/tfjs-core#1821
tafsiri
approved these changes
Jun 28, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained (waiting on @nsthorat and @tafsiri)
dsmilkov
added a commit
to tensorflow/tfjs-data
that referenced
this pull request
Jun 28, 2019
Adding `browser.crypto: false` to `package.json` results in not including crypto and it's dependencies when using `browserify` and `parcel` as bundlers for an end application. Test used: I made a hello-world js application that depends on tfjs-core and tfjs-data. Expected my bundle to be ~550kb, but I got 860kb. This fixed the issue. Analogous PR in tfjs-core: tensorflow/tfjs-core#1821
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
browser.crypto: falsetopackage.jsonresults in not including crypto and its dependencies when usingbrowserifyandparcelas bundlers for an end application.Test used:
I made a hello-world js application that depends on tfjs-core and build it with parcel.
Expected my bundle to be ~500kb, but I got 810kb. This fixed the issue.
This change is