Skip to content

Conversation

ccarpita
Copy link
Contributor

@ccarpita ccarpita commented Apr 27, 2022

This patch makes it possible to build TensorFlowLiteC_framework for arm64-simulator using the command bazel-5.0.0-darwin-arm64 build --config=ios_sim_arm64 -c opt //tensorflow/lite/ios:TensorFlowLiteC_framework

@mihaimaruseac
Copy link
Collaborator

Can you make this on master please? If it needs to be cherrypicked to fix 2.9 we can cherrypick from master afterwards.

@yyoon yyoon requested a review from yishuangP April 27, 2022 22:15
@gbaned gbaned requested a review from mihaimaruseac April 28, 2022 11:21
@mihaimaruseac mihaimaruseac changed the base branch from r2.9 to master April 28, 2022 15:03
@mihaimaruseac mihaimaruseac changed the base branch from master to r2.9 April 28, 2022 15:03
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be made on master branch, not r2.9

@ccarpita ccarpita changed the base branch from r2.9 to master April 28, 2022 16:24
@ccarpita ccarpita force-pushed the ccarpita/ios_sim_arm64_tflite_nopatch branch from 3e77604 to 7edee53 Compare April 28, 2022 16:25
@ccarpita ccarpita requested a review from mihaimaruseac April 29, 2022 16:25
@google-ml-butler google-ml-butler bot added the awaiting review Pull request awaiting review label Apr 29, 2022
@google-ml-butler google-ml-butler bot added kokoro:force-run Tests on submitted change ready to pull PR ready for merge process labels Apr 29, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label Apr 29, 2022
@mihaimaruseac mihaimaruseac changed the title build: add ios_arm_64 configuration, fix build issues for TFLite build: add ios_arm_64 configuration, fix build issues for TFLite Apr 29, 2022
@tensorflowbutler tensorflowbutler removed the awaiting review Pull request awaiting review label May 1, 2022
@google-ml-butler google-ml-butler bot added the kokoro:force-run Tests on submitted change label May 1, 2022
@kokoro-team kokoro-team removed the kokoro:force-run Tests on submitted change label May 1, 2022
@mself
Copy link

mself commented May 9, 2022

Does this PR need to be modified or are the CI failures transitory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull PR ready for merge process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants