Make step text depend on steps array #552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chihuahua
requested review from
jart,
teamdandelion and
wchargin
and removed request for
jart
Previously, the text atop image loaders (displaying step and wall time) would only depend on the step index. This was problematic because during reloads, the array of steps changes, but the number of sampled steps remains the same, so the text above individual images would not update. Fixes #550. Test plan: Run mnist_with_summaries.py: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/tutorials/mnist/mnist_with_summaries.py Start TensorBoard pointed at /tmp/tensorflow/mnist/logs/mnist_with_summaries, and navigate to the image dashboard. Notice that the step updates now when TensorBoard reloads, both during the periodic reload and during manually triggered reloads.
chihuahua
force-pushed
the
chihuahua-image-slider
branch
from
1f169ea to
3acd7da
Compare
|
Thanks for the quick fix! |
teamdandelion
approved these changes
Sep 21, 2017
jart
pushed a commit
to jart/tensorboard
that referenced
this pull request
Sep 23, 2017
Previously, the text atop image loaders (displaying step and wall time) would only depend on the step index. This was problematic because during reloads, the array of steps changes, but the number of sampled steps remains the same, so the text above individual images would not update. Fixes tensorflow#550. Test plan: Run mnist_with_summaries.py: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/tutorials/mnist/mnist_with_summaries.py Start TensorBoard pointed at /tmp/tensorflow/mnist/logs/mnist_with_summaries, and navigate to the image dashboard. Notice that the step updates now when TensorBoard reloads, both during the periodic reload and during manually triggered reloads.
jart
pushed a commit
that referenced
this pull request
Sep 26, 2017
Previously, the text atop image loaders (displaying step and wall time) would only depend on the step index. This was problematic because during reloads, the array of steps changes, but the number of sampled steps remains the same, so the text above individual images would not update. Fixes #550. Test plan: Run mnist_with_summaries.py: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/tutorials/mnist/mnist_with_summaries.py Start TensorBoard pointed at /tmp/tensorflow/mnist/logs/mnist_with_summaries, and navigate to the image dashboard. Notice that the step updates now when TensorBoard reloads, both during the periodic reload and during manually triggered reloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the text atop image loaders (displaying step and wall time)
would only depend on the step index. This was problematic because during
reloads, the array of steps changes, but the number of sampled steps
remains the same, so the text above individual images would not update.
Fixes #550.
Test plan: Run mnist_with_summaries.py:
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/examples/tutorials/mnist/mnist_with_summaries.py
Start TensorBoard pointed at
/tmp/tensorflow/mnist/logs/mnist_with_summaries, and navigate to the
image dashboard. Notice that the step updates now when TensorBoard
reloads, both during the periodic reload and during manually triggered
reloads.