Prevent computing unit norm of vectors of 0s #473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the embedding projector would take the norm of vectors of all 0s, resulting in vectors of all NaN values being used as part of PCA calculations. This change adds a guard to prevent that.
nsthorat
approved these changes
Sep 7, 2017
jart
pushed a commit
to jart/tensorboard
that referenced
this pull request
Sep 23, 2017
Previously, the embedding projector would take the norm of vectors of all 0s, resulting in vectors of all NaN values being used as part of PCA calculations. This change adds a guard to prevent that.
jart
pushed a commit
that referenced
this pull request
Sep 26, 2017
Previously, the embedding projector would take the norm of vectors of all 0s, resulting in vectors of all NaN values being used as part of PCA calculations. This change adds a guard to prevent that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the embedding projector would take the norm of vectors of all 0s, resulting in vectors of all NaN values being used as part of PCA calculations. This change adds a guard to prevent that.
Fixes #450.