Log exceptions during processing in the modal #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, when an error occurred while the projector was processing data (creating data sets and vectors, normalizing data points, computing PCA, etc), it would be logged to the console. This change uses a try ... catch block to make those exceptions appear as errors in the modal. This unfortunately hurts performance a bit because Chrome's V8 engine bypasses an optimized path for JS within a try ... catch block. However, so many people have taken issue with the lack of clarity surrounding projector bugs that I deem this change worth it.
The 'Error:' prefix is already in the error message.
nsthorat
approved these changes
Sep 7, 2017
dsmilkov
approved these changes
Sep 7, 2017
jart
pushed a commit
to jart/tensorboard
that referenced
this pull request
Sep 23, 2017
Previously, when an error occurred while the projector was processing data (creating data sets and vectors, normalizing data points, computing PCA, etc), it would be logged to the console. This change uses a try ... catch block to make those exceptions appear as errors in the modal. This unfortunately hurts performance a bit because Chrome's V8 engine bypasses an optimized path for JS within a try ... catch block. However, so many people have taken issue with the lack of clarity surrounding projector bugs that I deem this change worth it.
jart
pushed a commit
that referenced
this pull request
Sep 26, 2017
Previously, when an error occurred while the projector was processing data (creating data sets and vectors, normalizing data points, computing PCA, etc), it would be logged to the console. This change uses a try ... catch block to make those exceptions appear as errors in the modal. This unfortunately hurts performance a bit because Chrome's V8 engine bypasses an optimized path for JS within a try ... catch block. However, so many people have taken issue with the lack of clarity surrounding projector bugs that I deem this change worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when an error occurred while the projector was processing data (creating data sets and vectors, normalizing data points, computing PCA, etc), it would be logged to the console.
This change uses a try ... catch block to make those exceptions appear as errors in the modal.
This change unfortunately hurts performance a bit because Chrome's V8 engine bypasses an optimized path for JS within a try ... catch block. However, so many people have taken issue with the lack of clarity surrounding projector bugs that I deem this change worth it.