Skip to content

Upgrade for TensorFlow 2.6.0 #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2021

Conversation

saudet
Copy link
Contributor

@saudet saudet commented Aug 30, 2021

@karllessard This builds and runs fine, at least on my Linux machine, but as usual you'll probably want to take a look at the ops before merging this!

This was referenced Sep 3, 2021
@karllessard
Copy link
Collaborator

On it!

@karllessard karllessard force-pushed the upgrade-tensorflow-260 branch from 6f656f8 to b64414c Compare September 15, 2021 03:33
@google-cla
Copy link

google-cla bot commented Sep 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@karllessard karllessard added the CI build Triggers a full native build on a pull request label Sep 15, 2021
@karllessard
Copy link
Collaborator

@saudet , I've rebased the PR and it looks like you need to reconsent now.

Also, I've noticed that there are a lot of changes in the .bazelrc file of TensorFlow that we did not import in our copy, I'm not sure if we should copy it/merge it at each upgrade, wdyt?

@saudet
Copy link
Contributor Author

saudet commented Sep 15, 2021

@googlebot I consent.

@google-cla
Copy link

google-cla bot commented Sep 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@saudet
Copy link
Contributor Author

saudet commented Sep 15, 2021

@saudet , I've rebased the PR and it looks like you need to reconsent now.

Also, I've noticed that there are a lot of changes in the .bazelrc file of TensorFlow that we did not import in our copy, I'm not sure if we should copy it/merge it at each upgrade, wdyt?

Not sure what to say, this Bazel stuff is all really annoying.

@google-cla
Copy link

google-cla bot commented Sep 15, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Sep 16, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@karllessard
Copy link
Collaborator

@googlebot I consent.

@karllessard
Copy link
Collaborator

@saudet , I've rebased the PR and it looks like you need to reconsent now.
Also, I've noticed that there are a lot of changes in the .bazelrc file of TensorFlow that we did not import in our copy, I'm not sure if we should copy it/merge it at each upgrade, wdyt?

Not sure what to say, this Bazel stuff is all really annoying.

Yeah same here, it's hard to say what are the real impact of updating/not-updating this file... Ok let's merge it as is and we can update it later if we think we need to. Thanks @saudet!

@karllessard karllessard merged commit f6d0950 into tensorflow:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI build Triggers a full native build on a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants