[Quick Fix] Update op generation #375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Nett <[email protected]>
This was referenced Aug 28, 2021
|
A lot of changes here are undesirable, many ops that were classified before (e.g. under |
|
No, that's the thing, I didn't change anything, just re-ran op generation locally. Can you run it on your machine and compare it to what is here? |
|
Might be best to just do this as part of #378, and make sure to commit the newly generated files. |
|
Yes I was also thinking about cleaning that up while I'm working on #378, we can close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to re-run generation before merging init scopes. This fixes that. There's also a few ops that apparently weren't generated last time we added some? Not sure why, but they are in
ops.pb, so I'm guessing they just weren't committed.