Skip to content

Proto #2199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2023
Merged

Proto #2199

merged 2 commits into from
Mar 16, 2023

Conversation

@MarkDaoust
Copy link
Member

@MarkDaoust MarkDaoust commented Mar 11, 2023 •
edited
Loading

  • Add support for proto-plus
  • Make it possible to override the default filter list.

@MarkDaoust MarkDaoust requested a review from a team as a code owner March 11, 2023 01:21
@MarkDaoust MarkDaoust added the ready to pull Start merge process label Mar 11, 2023
markmcd
markmcd approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the context for this? Does the TF API include proto-plus now? If so, should we require it as a dep, so it's always present?

@github-actions github-actions bot added the lgtm Community-added approval label Mar 13, 2023
@MarkDaoust
Copy link
Member Author

MarkDaoust commented Mar 13, 2023

What's the context for this? Does the TF API include proto-plus now? If so, should we require it as a dep, so it's always present?

I was debugging it a local checkout, I'll explain more in the merge.

@copybara-service copybara-service bot merged commit f5619f5 into tensorflow:master Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markmcd markmcd markmcd approved these changes

Assignees

@markmcd markmcd

Labels

lgtm Community-added approval ready to pull Start merge process

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MarkDaoust @markmcd