This repository was archived by the owner on Dec 22, 2020. It is now read-only.
Remove redundant "namespacing" from type names #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* `Ed25519PublicKey` => `ed25519::PublicKey` * `Ed25519Signature` => `ed25519::Signature` * `EcdsaPublicKey` => `ecdsa::PublicKey` * `EcdsaSignature` => `ecdsa::Signature` These names were prefixed with the signature type previously to avoid clashes with traits of the same name (i.e. `signatory::PublicKey` and `signatory::Signature`) however the namespace clash can also be avoided by using the `ed25519` and `ecdsa` module names. This is considered a Rust best practice: rust-lang/rfcs#356
tarcieri
force-pushed
the
namespacing-fixups
branch
from
fdf1d29 to
35fd4ea
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ed25519PublicKey=>ed25519::PublicKeyEd25519Signature=>ed25519::SignatureEcdsaPublicKey=>ecdsa::PublicKeyEcdsaSignature=>ecdsa::SignatureThese names were prefixed with the signature type previously to avoid clashes with traits of the same name (i.e.
signatory::PublicKeyandsignatory::Signature) however the namespace clash can also be avoided by using theed25519andecdsamodule names.This is considered a Rust best practice:
rust-lang/rfcs#356