Skip to content

Conversation

@nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Sep 10, 2024

Proposed changes

This fixes a unit test and fixes a bunch of linting issues in the code.

Addresses #18

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 90.59829% with 11 lines in your changes missing coverage. Please review.

Project coverage is 90.61%. Comparing base (17603f2) to head (fb01e40).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
src/tm_data_types/helpers/byte_data_class.py 75.00% 0 Missing and 2 partials ⚠️
src/tm_data_types/io_factory_methods.py 33.33% 2 Missing ⚠️
.../tm_data_types/datum/waveforms/digital_waveform.py 80.00% 0 Missing and 1 partial ⚠️
src/tm_data_types/files_and_formats/csv/csv.py 80.00% 0 Missing and 1 partial ⚠️
...types/files_and_formats/csv/data_formats/analog.py 50.00% 1 Missing ⚠️
...ypes/files_and_formats/csv/data_formats/digital.py 0.00% 1 Missing ⚠️
src/tm_data_types/files_and_formats/mat/mat.py 88.88% 0 Missing and 1 partial ⚠️
src/tm_data_types/files_and_formats/wfm/wfm.py 90.90% 1 Missing ⚠️
.../tm_data_types/files_and_formats/wfm/wfm_format.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   90.19%   90.61%   +0.41%     
==========================================
  Files          28       28              
  Lines        1805     1800       -5     
  Branches      276      275       -1     
==========================================
+ Hits         1628     1631       +3     
+ Misses        111      105       -6     
+ Partials       66       64       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

u625355
u625355 previously approved these changes Sep 11, 2024
Copy link
Contributor

@u625355 u625355 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the trigger index change, except that rest seems fine.
@tekperson , can comment on that.

@nfelt14 nfelt14 enabled auto-merge (squash) September 11, 2024 18:00
@github-actions
Copy link

github-actions bot commented Sep 11, 2024

Breaking API Changes

src/tm_data_types/datum/waveforms/waveform.py:90: Waveform.trigger_index:
Attribute value was changed:
  Old: 0.0
  New: None

src/tm_data_types/helpers/instrument_series.py:11: InstrumentSeriesDataStyle:
Public object points to a different kind of object:
  Old: attribute
  New: class

src/tm_data_types/helpers/instrument_series.py:18: Endian:
Public object points to a different kind of object:
  Old: attribute
  New: class

Link to workflow run

@github-actions
Copy link

github-actions bot commented Sep 11, 2024

Test Results (ubuntu)

path passed subtotal
tests/test_tm_data_types.py 13 13
TOTAL 13 13

Link to workflow run

@github-actions
Copy link

github-actions bot commented Sep 11, 2024

Test Results (windows)

path passed subtotal
tests\test_tm_data_types.py 13 13
TOTAL 13 13

Link to workflow run

@github-actions
Copy link

github-actions bot commented Sep 11, 2024

Test Results (macos)

path passed subtotal
tests/test_tm_data_types.py 13 13
TOTAL 13 13

Link to workflow run

@nfelt14 nfelt14 disabled auto-merge September 11, 2024 18:41
@nfelt14 nfelt14 merged commit d620f90 into main Sep 11, 2024
64 checks passed
@nfelt14 nfelt14 deleted the nfelt14/misc-updates branch September 11, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants