test: add accessor methods and improve config change tests

Author: waveywaves

.serena/.gitignore

@@ -0,0 +1 @@
+/cache

.serena/project.yml

@@ -0,0 +1,67 @@
+# language of the project (csharp, python, rust, java, typescript, go, cpp, or ruby)
+#  * For C, use cpp
+#  * For JavaScript, use typescript
+# Special requirements:
+#  * csharp: Requires the presence of a .sln file in the project folder.
+language: go
+
+# whether to use the project's gitignore file to ignore files
+# Added on 2025-04-07
+ignore_all_files_in_gitignore: true
+# list of additional paths to ignore
+# same syntax as gitignore, so you can use * and **
+# Was previously called `ignored_dirs`, please update your config if you are using that.
+# Added (renamed) on 2025-04-07
+ignored_paths: []
+
+# whether the project is in read-only mode
+# If set to true, all editing tools will be disabled and attempts to use them will result in an error
+# Added on 2025-04-18
+read_only: false
+
+# list of tool names to exclude. We recommend not excluding any tools, see the readme for more details.
+# Below is the complete list of tools for convenience.
+# To make sure you have the latest list of tools, and to view their descriptions, 
+# execute `uv run scripts/print_tool_overview.py`.
+#
+#  * `activate_project`: Activates a project by name.
+#  * `check_onboarding_performed`: Checks whether project onboarding was already performed.
+#  * `create_text_file`: Creates/overwrites a file in the project directory.
+#  * `delete_lines`: Deletes a range of lines within a file.
+#  * `delete_memory`: Deletes a memory from Serena's project-specific memory store.
+#  * `execute_shell_command`: Executes a shell command.
+#  * `find_referencing_code_snippets`: Finds code snippets in which the symbol at the given location is referenced.
+#  * `find_referencing_symbols`: Finds symbols that reference the symbol at the given location (optionally filtered by type).
+#  * `find_symbol`: Performs a global (or local) search for symbols with/containing a given name/substring (optionally filtered by type).
+#  * `get_current_config`: Prints the current configuration of the agent, including the active and available projects, tools, contexts, and modes.
+#  * `get_symbols_overview`: Gets an overview of the top-level symbols defined in a given file.
+#  * `initial_instructions`: Gets the initial instructions for the current project.
+#     Should only be used in settings where the system prompt cannot be set,
+#     e.g. in clients you have no control over, like Claude Desktop.
+#  * `insert_after_symbol`: Inserts content after the end of the definition of a given symbol.
+#  * `insert_at_line`: Inserts content at a given line in a file.
+#  * `insert_before_symbol`: Inserts content before the beginning of the definition of a given symbol.
+#  * `list_dir`: Lists files and directories in the given directory (optionally with recursion).
+#  * `list_memories`: Lists memories in Serena's project-specific memory store.
+#  * `onboarding`: Performs onboarding (identifying the project structure and essential tasks, e.g. for testing or building).
+#  * `prepare_for_new_conversation`: Provides instructions for preparing for a new conversation (in order to continue with the necessary context).
+#  * `read_file`: Reads a file within the project directory.
+#  * `read_memory`: Reads the memory with the given name from Serena's project-specific memory store.
+#  * `remove_project`: Removes a project from the Serena configuration.
+#  * `replace_lines`: Replaces a range of lines within a file with new content.
+#  * `replace_symbol_body`: Replaces the full definition of a symbol.
+#  * `restart_language_server`: Restarts the language server, may be necessary when edits not through Serena happen.
+#  * `search_for_pattern`: Performs a search for a pattern in the project.
+#  * `summarize_changes`: Provides instructions for summarizing the changes made to the codebase.
+#  * `switch_modes`: Activates modes by providing a list of their names
+#  * `think_about_collected_information`: Thinking tool for pondering the completeness of collected information.
+#  * `think_about_task_adherence`: Thinking tool for determining whether the agent is still on track with the current task.
+#  * `think_about_whether_you_are_done`: Thinking tool for determining whether the task is truly completed.
+#  * `write_memory`: Writes a named memory (for future reference) to Serena's project-specific memory store.
+excluded_tools: []
+
+# initial prompt for the project. It will always be given to the LLM upon activating the project
+# (contrary to the memories, which are loaded on demand).
+initial_prompt: ""
+
+project_name: "pipeline2"

pkg/remoteresolution/resolver/framework/cache/cache.go

@@ -34,17 +34,19 @@ var _ resolutionframework.ConfigWatcher = (*resolverCache)(nil)
 // resolverCache is a wrapper around utilcache.LRUExpireCache that provides
 // type-safe methods for caching resolver results.
 type resolverCache struct {
-	cache  *utilcache.LRUExpireCache
-	logger *zap.SugaredLogger
-	ttl    time.Duration
-	clock  Clock
+	cache   *utilcache.LRUExpireCache
+	logger  *zap.SugaredLogger
+	ttl     time.Duration
+	maxSize int
+	clock   Clock
 }
 
 func newResolverCache(maxSize int, ttl time.Duration) *resolverCache {
 	return &resolverCache{
-		cache: utilcache.NewLRUExpireCache(maxSize),
-		ttl:   ttl,
-		clock: realClock{},
+		cache:   utilcache.NewLRUExpireCache(maxSize),
+		ttl:     ttl,
+		maxSize: maxSize,
+		clock:   realClock{},
 	}
 }
 
@@ -56,7 +58,17 @@ func (c *resolverCache) GetConfigName(_ context.Context) string {
 // withLogger returns a new ResolverCache instance with the provided logger.
 // This prevents state leak by not storing logger in the global singleton.
 func (c *resolverCache) withLogger(logger *zap.SugaredLogger) *resolverCache {
-	return &resolverCache{logger: logger, cache: c.cache, ttl: c.ttl, clock: c.clock}
+	return &resolverCache{logger: logger, cache: c.cache, ttl: c.ttl, maxSize: c.maxSize, clock: c.clock}
+}
+
+// TTL returns the time-to-live duration for cache entries.
+func (c *resolverCache) TTL() time.Duration {
+	return c.ttl
+}
+
+// MaxSize returns the maximum number of entries the cache can hold.
+func (c *resolverCache) MaxSize() int {
+	return c.maxSize
 }
 
 // Get retrieves a cached resource by resolver type and parameters, returning

pkg/remoteresolution/resolver/framework/cache/configstore_test.go

@@ -198,7 +198,12 @@ func TestParseCacheConfigMap(t *testing.T) {
 }
 
 func TestOnCacheConfigChanged(t *testing.T) {
-	// Test that onCacheConfigChanged updates the shared cache
+	ctx := logtesting.TestContextWithLogger(t)
+
+	// Ensure cache is initialized first
+	_ = Get(ctx)
+
+	// Test that onCacheConfigChanged updates the shared cache with new config values
 	config := &cacheConfig{
 		maxSize: 500,
 		ttl:     10 * time.Minute,
@@ -207,25 +212,55 @@ func TestOnCacheConfigChanged(t *testing.T) {
 	// Call onCacheConfigChanged to update the shared cache
 	onCacheConfigChanged("test-config", config)
 
-	// Verify the shared cache was updated by checking we can still get it
-	// We can't directly verify the size/ttl without accessing the internal cache,
-	// but we can verify it doesn't panic and returns a valid cache
-	ctx := logtesting.TestContextWithLogger(t)
+	// Verify the shared cache was updated with the correct config values
 	cache := Get(ctx)
 	if cache == nil {
-		t.Error("Expected cache after config change but got nil")
+		t.Fatal("Expected cache after config change but got nil")
+	}
+
+	// Verify TTL was applied
+	if cache.TTL() != config.ttl {
+		t.Errorf("Expected TTL to be %v, got %v", config.ttl, cache.TTL())
+	}
+
+	// Verify MaxSize was applied
+	if cache.MaxSize() != config.maxSize {
+		t.Errorf("Expected MaxSize to be %d, got %d", config.maxSize, cache.MaxSize())
 	}
 }
 
 func TestOnCacheConfigChangedWithInvalidType(t *testing.T) {
+	// First, set up a known good config
+	goodConfig := &cacheConfig{
+		maxSize: defaultCacheSize,
+		ttl:     defaultExpiration,
+	}
+	onCacheConfigChanged("test-config", goodConfig)
+
+	ctx := logtesting.TestContextWithLogger(t)
+	cacheBefore := Get(ctx)
+	if cacheBefore == nil {
+		t.Fatal("Expected cache before invalid config change")
+	}
+	ttlBefore := cacheBefore.TTL()
+	maxSizeBefore := cacheBefore.MaxSize()
+
 	// Test that onCacheConfigChanged handles invalid types gracefully
-	// This should not panic
+	// This should not panic and should preserve the existing cache
 	onCacheConfigChanged("test-config", "invalid-type")
 
-	// Verify we can still get the cache
-	ctx := logtesting.TestContextWithLogger(t)
-	cache := Get(ctx)
-	if cache == nil {
-		t.Error("Expected cache after invalid config change but got nil")
+	// Verify we can still get the cache and it wasn't modified
+	cacheAfter := Get(ctx)
+	if cacheAfter == nil {
+		t.Fatal("Expected cache after invalid config change but got nil")
+	}
+
+	// Verify cache config wasn't changed by invalid input
+	if cacheAfter.TTL() != ttlBefore {
+		t.Errorf("Expected TTL to remain %v after invalid config, got %v", ttlBefore, cacheAfter.TTL())
+	}
+
+	if cacheAfter.MaxSize() != maxSizeBefore {
+		t.Errorf("Expected MaxSize to remain %d after invalid config, got %d", maxSizeBefore, cacheAfter.MaxSize())
 	}
 }