test: remove unnecessary tests in cache package

Author: waveywaves

pkg/remoteresolution/resolver/framework/cache/annotated_resource_test.go

@@ -43,90 +43,68 @@ func (m *mockResolvedResource) RefSource() *v1.RefSource {
 }
 
 func TestNewAnnotatedResource(t *testing.T) {
-	tests := []struct {
-		name         string
-		resolverType string
-		hasExisting  bool
-	}{
-		{
-			name:         "with existing annotations",
-			resolverType: "bundles",
-			hasExisting:  true,
-		},
-		{
-			name:         "without existing annotations",
-			resolverType: "git",
-			hasExisting:  false,
+	// Create mock resource with existing annotations to test preservation
+	mockAnnotations := map[string]string{
+		"existing-key": "existing-value",
+	}
+
+	mockResource := &mockResolvedResource{
+		data:        []byte("test data"),
+		annotations: mockAnnotations,
+		refSource: &v1.RefSource{
+			URI: "test-uri",
 		},
 	}
 
-	for _, tt := range tests {
-		t.Run(tt.name, func(t *testing.T) {
-			// Create mock resource
-			mockAnnotations := make(map[string]string)
-			if tt.hasExisting {
-				mockAnnotations["existing-key"] = "existing-value"
-			}
-
-			mockResource := &mockResolvedResource{
-				data:        []byte("test data"),
-				annotations: mockAnnotations,
-				refSource: &v1.RefSource{
-					URI: "test-uri",
-				},
-			}
-
-			// Create fake clock with fixed time for deterministic testing
-			fixedTime := time.Date(2025, 1, 15, 10, 30, 0, 0, time.UTC)
-			fc := &fakeClock{now: fixedTime}
-
-			// Create annotated resource
-			annotated := newAnnotatedResource(mockResource, tt.resolverType, cacheOperationStore, fc)
-
-			// Verify data is preserved
-			if string(annotated.Data()) != "test data" {
-				t.Errorf("Expected data 'test data', got '%s'", string(annotated.Data()))
-			}
-
-			// Verify annotations are added
-			annotations := annotated.Annotations()
-			if annotations[cacheAnnotationKey] != "true" {
-				t.Errorf("Expected cache annotation to be 'true', got '%s'", annotations[cacheAnnotationKey])
-			}
-
-			if annotations[cacheResolverTypeKey] != tt.resolverType {
-				t.Errorf("Expected resolver type '%s', got '%s'", tt.resolverType, annotations[cacheResolverTypeKey])
-			}
-
-			// Verify timestamp is as expected
-			expectedTimestamp := fixedTime.Format(time.RFC3339)
-			timestamp := annotations[cacheTimestampKey]
-			if timestamp != expectedTimestamp {
-				t.Errorf("Expected cache timestamp to be %s, got %s", expectedTimestamp, timestamp)
-			}
-
-			// Verify timestamp is valid RFC3339 format
-			_, err := time.Parse(time.RFC3339, timestamp)
-			if err != nil {
-				t.Errorf("Expected valid RFC3339 timestamp, got error: %v", err)
-			}
-
-			// Verify cache operation is set
-			if annotations[cacheOperationKey] != cacheOperationStore {
-				t.Errorf("Expected cache operation '%s', got '%s'", cacheOperationStore, annotations[cacheOperationKey])
-			}
-
-			// Verify existing annotations are preserved
-			if tt.hasExisting {
-				if annotations["existing-key"] != "existing-value" {
-					t.Errorf("Expected existing annotation to be preserved, got '%s'", annotations["existing-key"])
-				}
-			}
-
-			// Verify RefSource is preserved
-			if annotated.RefSource().URI != "test-uri" {
-				t.Errorf("Expected RefSource URI 'test-uri', got '%s'", annotated.RefSource().URI)
-			}
-		})
+	// Create fake clock with fixed time for deterministic testing
+	fixedTime := time.Date(2025, 1, 15, 10, 30, 0, 0, time.UTC)
+	fc := &fakeClock{now: fixedTime}
+
+	resolverType := "bundles"
+
+	// Create annotated resource
+	annotated := newAnnotatedResource(mockResource, resolverType, cacheOperationStore, fc)
+
+	// Verify data is preserved
+	if string(annotated.Data()) != "test data" {
+		t.Errorf("Expected data 'test data', got '%s'", string(annotated.Data()))
+	}
+
+	// Verify annotations are added
+	annotations := annotated.Annotations()
+	if annotations[cacheAnnotationKey] != "true" {
+		t.Errorf("Expected cache annotation to be 'true', got '%s'", annotations[cacheAnnotationKey])
+	}
+
+	if annotations[cacheResolverTypeKey] != resolverType {
+		t.Errorf("Expected resolver type '%s', got '%s'", resolverType, annotations[cacheResolverTypeKey])
+	}
+
+	// Verify timestamp is as expected
+	expectedTimestamp := fixedTime.Format(time.RFC3339)
+	timestamp := annotations[cacheTimestampKey]
+	if timestamp != expectedTimestamp {
+		t.Errorf("Expected cache timestamp to be %s, got %s", expectedTimestamp, timestamp)
+	}
+
+	// Verify timestamp is valid RFC3339 format
+	_, err := time.Parse(time.RFC3339, timestamp)
+	if err != nil {
+		t.Errorf("Expected valid RFC3339 timestamp, got error: %v", err)
+	}
+
+	// Verify cache operation is set
+	if annotations[cacheOperationKey] != cacheOperationStore {
+		t.Errorf("Expected cache operation '%s', got '%s'", cacheOperationStore, annotations[cacheOperationKey])
+	}
+
+	// Verify existing annotations are preserved
+	if annotations["existing-key"] != "existing-value" {
+		t.Errorf("Expected existing annotation to be preserved, got '%s'", annotations["existing-key"])
+	}
+
+	// Verify RefSource is preserved
+	if annotated.RefSource().URI != "test-uri" {
+		t.Errorf("Expected RefSource URI 'test-uri', got '%s'", annotated.RefSource().URI)
 	}
 }

pkg/remoteresolution/resolver/framework/cache/configstore_test.go

@@ -197,14 +197,6 @@ func TestParseCacheConfigMap(t *testing.T) {
 	}
 }
 
-func TestGetCacheConfigName(t *testing.T) {
-	// Test default config name
-	configName := getCacheConfigName()
-	if configName != defaultConfigMapName {
-		t.Errorf("getCacheConfigName() = %q, want %q", configName, defaultConfigMapName)
-	}
-}
-
 func TestOnCacheConfigChanged(t *testing.T) {
 	// Test that onCacheConfigChanged updates the shared cache
 	config := &cacheConfig{