This repository was archived by the owner on Apr 28, 2025. It is now read-only.
Package shared Javascript with yarn and webpack #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjdo
approved these changes
Aug 29, 2017
|
In regards to your statement on |
|
Thanks, @tjdo, I will try that out! |
jmckible
commented
Aug 29, 2017
| @@ -16,7 +16,7 @@ UI.load -> | |||
| initialVal = null | |||
|
|
|||
| if $(datepicker).val().length | |||
| initialVal = moment($(datepicker).val()).format('MM/DD/YYYY h:mm A') | |||
| initialVal = moment(new Date($(datepicker).val())).format('MM/DD/YYYY h:mm A') | |||
There was a problem hiding this comment.
To quiet a warning
app/javascripts/app/filters.coffee
Outdated
| @@ -1,7 +1,6 @@ | |||
| updateFilters = -> | |||
| if $('#filter-bar').exists() | |||
| $("#filter-bar").stick_in_parent(parent: '#main', offset_top: 88) | |||
| $(document.body).trigger("sticky_kit:recalc") | |||
There was a problem hiding this comment.
Will investigate recovering this. Not sure what it was removed.
app/javascripts/app/nav.coffee
Outdated
| # =================================================== | ||
|
|
||
| UI.load -> | ||
| $("#subnav.sticky-subnav").stick_in_parent(bottoming: false, offset_top: $('#nav').height()) |
|
|
||
| $.fn.enable = -> | ||
| this.each -> | ||
| $(this).prop('disabled', false) | ||
| $(this).removeClass('disabled').prop('disabled', false) |
There was a problem hiding this comment.
Convenience for Engage. I don't think this will any downstream effects.
There was a problem hiding this comment.
I dont see any downstream effects with this either
| hideLoadingSpinner() | ||
| # TODO commented out with webpack conversion | ||
| # $(window).unload -> | ||
| # hideLoadingSpinner() |
There was a problem hiding this comment.
Will investigate re-adding.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@techvalidate/engineering For your consideration. Feedback welcome. This change enables the refactor at techvalidate/engage#451
This PR begins the process of converting our Javascript asset pipeline to webpack. There does not seem to be a current path forward with engines and webpack, as of rails/webpacker#21
My original thought was to spin up another pano-js repository to cleanly separate our shared ruby and js. However, I feel like we're already juggling too much will multiple production version of Pano and adding yet another repo seems like it would further complicate matters.
The Changes
Rails convention is to store webpack'd files in
app/javascripts, notapp/assets/javascriptsSince the asset pipeline is not building the
requireload order, those calls are unnecessary.UIis now exported and loaded on the window via ProvidedPluginDependencies are loaded via package.json
Statements of Value
I still believe in coffeescript! Given the sprinkle nature of the majority of our js (especially
UI), I have not found a situation wherein coffeescript does not provide a more concise solution to the problems we are trying to solve.Given the breadth and depth of our discussions around Javascript, I expect this will be a controversial position. I am open to any code examples you feel my sway me. As always: strong opinions, weakly held.
To Be Investigated
The
mainattribute in package.json allows for easy bundling of the global js. Any way to apply this to namespaces?Any way to simplify global loading with ProvidedPlugin in shared.js?
I have not found an equivalent of
require_treeWhat about CSS from dependencies? Do we need it, and if so, how do we reference it?