Update VCRPY test connector pattern to new standard #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently receiving this error when running tests locally. This error happens after the tests pass locally for several tries. (venv) tzturner@ip-10-225-88-150:~/projects/secops-splunk-null-router$ make test
venv/bin/python -m flake8 tests/test_connector.py
touch .lint
venv/bin/python -m mypy tests/test_connector.py
tests/test_connector.py:7: error: Cannot find implementation or library stub for module named "phsoar_null_router.soar_null_router_connector" [import]
tests/test_connector.py:7: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
Found 1 error in 1 file (checked 1 source file)
make: *** [Makefile:53: .static] Error 1 |
tzturner
force-pushed
the
feature/issue-31
branch
2 times, most recently
from
10b798d to
309a817
Compare
tzturner
force-pushed
the
feature/issue-31
branch
from
4022190 to
0de4bc7
Compare
5 tasks
edthedev
reviewed
May 11, 2023
.github/workflows/deploy.yml
Outdated
Comment on lines
30
to
31
| make deploy | ||
| # Waiting on deployment fix | ||
| # make deploy |
There was a problem hiding this comment.
The deployment fix is merged, so we can un-comment this now.
Suggested change
| make deploy | |
| # Waiting on deployment fix | |
| # make deploy | |
| make deploy |
edthedev
previously approved these changes
May 11, 2023
mpitcel
previously approved these changes
May 11, 2023
tzturner
force-pushed
the
feature/issue-31
branch
from
b302029 to
c2a01fc
Compare
zdc217
approved these changes
May 15, 2023
edthedev
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #31