Replace fieldsets with divs. #109
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #108. There are now no more mentions of "fieldset" within the codebase except for a TODO in
ToggleGroup.svelte
.Note that I had a large number of warnings/errors in my VS Code project, but everything built (and seemed to behave) just fine. May have just misconfigured something on my end, idk.
<div>
elements a "group" role.disabled
and made sure to pass the parent component's state to it since the<fieldset>
previously would've affected nested form fields'disabled
state automatically.Input
component did not have adisabled
property, so I had to add one.If I missed anything, please feel free to let me know (or just fix w/ a follow-up).