Skip to content

Update prefer-no-devDependencies to standard rule type #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 12, 2020
Merged

Update prefer-no-devDependencies to standard rule type #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecba4f2
Update prefer-no-devDependencies to standard rule type
tclindner Apr 12, 2020
6d45afd
Merge branch 'master' into prefer-no-devDependencies
tclindner Apr 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/rules/prefer-no-devDependencies.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const LintIssue = require('./../LintIssue');
const lintId = 'prefer-no-devDependencies';
const nodeName = 'devDependencies';
const message = 'devDependencies should not be defined';
const ruleType = 'optionalObject';
const ruleType = 'standard';

const lint = (packageJsonData, severity) => {
if (exists(packageJsonData, nodeName)) {
Expand Down
4 changes: 2 additions & 2 deletions test/unit/rules/prefer-no-devDependencies.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ const nodeName = 'devDependencies';

describe('prefer-no-devDependencies Unit Tests', () => {
describe('a rule type value should be exported', () => {
test('it should equal "optionalObject"', () => {
expect(ruleType).toStrictEqual('optionalObject');
test('it should equal "standard"', () => {
expect(ruleType).toStrictEqual('standard');
});
});

Expand Down