Fix duplicate definition of stx::in_place and related #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4.
In some cases,
optional.hppandvariant.hppstill could not be includedin the same translation unit:
(1) If the user included
variant.hppfirst andoptional.hppsecond andif
<variant>was available, we'd see duplicateinplace_tandinplace.(2) If the user included
optional.hppfirst andvariant.hppsecond andif
<optional>was available, we'd see duplicateinplace_tandinplace.(3) If the user included
optional.hppfirst andvariant.hppsecond andif
<optional>was not available, we'd see duplicatein_place_type_t,in_place_type,in_place_index_t, andin_place_index.This improves on 6da04dc.
This is similar to the fix proposed in #8, but goes a step further and removes the
in_place_type_tandin_place_index_tfromoptional.hpp-- they are not related to using optional (only variant and any), and when we're using<optional>or<experimental/optional>they were not being aliased anyway, so they were only conditionally provided by stx. It seemed better to remove them, instead of trying to make them play nice with variant.hpp.