JSONException calling getSavedQueries with the newer JSon library

[eduardo-jose-pereira]

• Got the following exception calling getSavedQueries.
• It seems that the field "is_public" is a boolean not a string.
• I am using Redmine 2.0.3.stable
• I added the method getBooleanOrNull to JsonInput and changed the method RedmineJSONParser.parseSavedQuery to use JsonInput.getBooleanOrNull instead of getStringOrNull and that seems to fix the problem.

com.taskadapter.redmineapi.RedmineFormatException: org.json.JSONException: JSONObject["is_public"] not a string.
at com.taskadapter.redmineapi.internal.Transport.getObjectsList(Transport.java:386)
at com.taskadapter.redmineapi.internal.Transport.getObjectsList(Transport.java:335)
at com.taskadapter.redmineapi.RedmineManager.getSavedQueries(RedmineManager.java:440)
at aA.TicketExample.showQueries(TicketExample.java:47)
at aA.TicketExample.main(TicketExample.java:27)
Caused by: org.json.JSONException: JSONObject["is_public"] not a string.
at org.json.JSONObject.getString(JSONObject.java:644)
at com.taskadapter.redmineapi.internal.json.JsonInput.getStringOrNull(JsonInput.java:128)
at com.taskadapter.redmineapi.internal.RedmineJSONParser.parseSavedQuery(RedmineJSONParser.java:224)
at com.taskadapter.redmineapi.internal.RedmineJSONParser$15.parse(RedmineJSONParser.java:139)
at com.taskadapter.redmineapi.internal.RedmineJSONParser$15.parse(RedmineJSONParser.java:1)
at com.taskadapter.redmineapi.internal.json.JsonInput.getListOrNull(JsonInput.java:58)
at com.taskadapter.redmineapi.internal.Transport.getObjectsList(Transport.java:375)
... 4 more

[eduardo-jose-pereira]

the same problem happened with is_default and is_closed in RedmineJSONParser.parseStatus

[maxkar]

Hello, Eduardo.

Do you use newer JSON version? Our tests are run using JSON library from maven repository and thus does not detect such problem.
Neverless, I implemented proposed changes (both in saved queries and statuses). It is a correct way to read a booleans. Now remine-java-api should work in your configuration.

[alexeyOnGitHub]

this issue seems important enough to release a new version. Maxim, are we ready for the release?

[maxkar]

Yes, we a ready.

[alexeyOnGitHub]

this problem was reproducible on the newest JSon library, which is not present in Maven Central. I will release a new version of Redmine Java API today. it will be compatible with both old and new JSon library.

[deepaksindhu]

Hi All, I am new to Android. I am using redmine-java-api.jar in my android project. The project compiles fine but at run time I am getting below exception. I have added Redmine-java-api.jar as external JAR and added to project build path. my android environment is 2.2. please suggest.
Also, to resolve this issue, I downloaded and added the following dependency jar's commons-codec-1.4.jar, httpcore-4.2.1.jar, httpclient-4.2.jar, json-org.jar

(java.lang.NoSuchMethodError: org.apache.http.conn.ssl.SSLSocketFactory.
08-20 09:08:48.344: E/AndroidRuntime(333): at com.taskadapter.redmineapi.internal.comm.naivessl.NaiveSSLFactory.createNaiveSSLSocketFactory(NaiveSSLFactory.java:35)
08-20 09:08:48.344: E/AndroidRuntime(333): at com.taskadapter.redmineapi.internal.comm.HttpUtil.createConnectionManager(HttpUtil.java:53)
08-20 09:08:48.344: E/AndroidRuntime(333): at com.taskadapter.redmineapi.internal.comm.BaseCommunicator.(BaseCommunicator.java:30)
08-20 09:08:48.344: E/AndroidRuntime(333): at com.taskadapter.redmineapi.internal.Transport.(Transport.java:141)
08-20 09:08:48.344: E/AndroidRuntime(333): at com.taskadapter.redmineapi.RedmineManager.(RedmineManager.java:96)
08-20 09:08:48.344: E/AndroidRuntime(333): at com.taskadapter.redmineapi.RedmineManager.(RedmineManager.java:77)
08-20 09:08:48.344: E/AndroidRuntime(333): at com.example.againred.MainActivity.onCreate(MainActivity.java:20)