Change file type to image type and add preview #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The file type always used the media uploader for images so rename it to image field type and add a preview for the image. Updated the examples. Signed-off-by: Roi Dayan <[email protected]>
Open
Contributor
Author
|
the preview appears below the input+description. preview is being updated if text being modified manually or through the media uploader. |
Contributor
Author
|
this commit also makes pr #42 redundant |
Contributor
Author
|
will make new image type after the merge of #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file type always used the media uploader for images
so rename it to image field type and add a preview for the image.
Updated the examples.
Signed-off-by: Roi Dayan [email protected]