Bump tarantool-python submodule (remove test-run) #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change removes the test-run submodule from `lib/tarantool-python`. The idea is to get rid of this 'recursive' nesting of test-run and tarantool-python submodules into each other. Those nested submodules contain old resivions of the code. It confuses linters, which looking for code recursively (such as luacheck). See [1] for details. After this commit we can eliminate the `test-run/**/*.lua` exclusion from `.luacheckrc` in tarantool. As the side effect, `git clone --recursive <...>` will be faster. [1]: tarantool/tarantool-python#189 Follows up PR #266
Totktonada
added
the
code health
Totktonada
added a commit
to tarantool/tarantool
that referenced
this pull request
Mar 8, 2021
This commit updates test-run with an update of tarantool-python, which eliminates the test-run submodule from tarantool-python. In other words, we have no test-run submodule inside test-run anymore. The goal is to don't confuse luacheck with old revisions of test-run / tarantool-python code and to make recursive clone faster. See [1] and [2] for details. [1]: tarantool/test-run#268 [2]: tarantool/tarantool-python@dccf18f
Totktonada
added a commit
to tarantool/tarantool
that referenced
this pull request
Mar 8, 2021
This commit updates test-run with an update of tarantool-python, which eliminates the test-run submodule from tarantool-python. In other words, we have no test-run submodule inside test-run anymore. The goal is to don't confuse luacheck with old revisions of test-run / tarantool-python code and to make recursive clone faster. See [1] and [2] for details. [1]: tarantool/test-run#268 [2]: tarantool/tarantool-python@dccf18f (cherry picked from commit 6a640ee)
Totktonada
added a commit
to tarantool/tarantool
that referenced
this pull request
Mar 8, 2021
This commit updates test-run with an update of tarantool-python, which eliminates the test-run submodule from tarantool-python. In other words, we have no test-run submodule inside test-run anymore. The goal is to don't confuse luacheck with old revisions of test-run / tarantool-python code and to make recursive clone faster. See [1] and [2] for details. [1]: tarantool/test-run#268 [2]: tarantool/tarantool-python@dccf18f (cherry picked from commit 6a640ee)
Totktonada
added a commit
to tarantool/tarantool
that referenced
this pull request
Mar 8, 2021
This commit updates test-run with an update of tarantool-python, which eliminates the test-run submodule from tarantool-python. In other words, we have no test-run submodule inside test-run anymore. The goal is to don't confuse luacheck with old revisions of test-run / tarantool-python code and to make recursive clone faster. See [1] and [2] for details. [1]: tarantool/test-run#268 [2]: tarantool/tarantool-python@dccf18f (cherry picked from commit 6a640ee)
|
Updated the test-run submodule in tarantool in the following commits:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the test-run submodule from
lib/tarantool-python.The idea is to get rid of this 'recursive' nesting of test-run and
tarantool-python submodules into each other. Those nested submodules
contain old resivions of the code. It confuses linters, which looking
for code recursively (such as luacheck). See 1 for details.
After this commit we can eliminate the
test-run/**/*.luaexclusionfrom
.luacheckrcin tarantool.As the side effect,
git clone --recursive <...>will be faster.Follows up PR #266