Skip to content

Update tarantool-python to 0.7.1-1-g8847b8c #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Totktonada
Copy link
Member

@Totktonada Totktonada commented Jan 18, 2021

This update brings tarantool-python changes from releases 0.6.61,
0.7.0 and 0.7.1 and the unreleased change 1 regarding unification of
the __str__ Response method across Python 2 and Python 3. Look at the
release notes 2 for the list of changes in the connector.

We need 1 to obtain the same test result on different Python versions
for tarantool's box-py/call.test.py test.

Part of #20
Part of tarantool/tarantool#5652

Footnotes

  1. Except replacing of yaml.load() with yaml.safe_load() in tests,
    which is already here.

This update brings tarantool-python changes from releases 0.6.6[^1],
0.7.0 and 0.7.1 and the unreleased change [1] regarding unification of
the __str__ Response method across Python 2 and Python 3. Look at the
release notes [2] for the list of changes in the connector.

We need [1] to obtain the same test result on different Python versions
for tarantool's box-py/call.test.py test.

[^1]: Except replacing of yaml.load() with yaml.safe_load() in tests,
      which is already here.

[1]: tarantool/tarantool-python#186
[2]: https://github.com/tarantool/tarantool-python/releases

Part of #20
Part of tarantool/tarantool#5652
@ligurio
Copy link
Member

ligurio commented Jan 18, 2021

I propose to include changes in PR tarantool/tarantool-python#187 too, because it is required to completely fix box-py/call.test.py test.

@ligurio ligurio mentioned this pull request Jan 18, 2021
Copy link
Member

@ligurio ligurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Totktonada
Copy link
Member Author

Thanks, I'll proceed soon.

@Totktonada Totktonada merged commit 72f8b89 into master Jan 20, 2021
@Totktonada Totktonada deleted the Totktonada/update-tarantool-python-0.7.1-1-g8847b8c branch January 20, 2021 16:12
@Totktonada Totktonada restored the Totktonada/update-tarantool-python-0.7.1-1-g8847b8c branch January 20, 2021 16:12
@Totktonada Totktonada deleted the Totktonada/update-tarantool-python-0.7.1-1-g8847b8c branch January 20, 2021 16:12
Totktonada added a commit to tarantool/tarantool that referenced this pull request Jan 20, 2021
Update the test-run submodule with updating its tarantool-python
submodule with the Response.__str__() change, which unifies behaviour
between Python 2 and Python 3. We lean on this in the
box-py/call.test.py test. See more in [1].

Updated the box-py/iproto.test.py test, because it is confused by the
new IPROTO_SQL_INFO_* constants, introduced in the tarantool-python
connector in [2].

Part of tarantool/test-run#20
Part of #5652

[1]: tarantool/test-run#264
[2]: tarantool/tarantool-python@9d3573e
Totktonada added a commit to tarantool/tarantool that referenced this pull request Jan 20, 2021
Update the test-run submodule with updating its tarantool-python
submodule with the Response.__str__() change, which unifies behaviour
between Python 2 and Python 3. We lean on this in the
box-py/call.test.py test. See more in [1].

Updated the box-py/iproto.test.py test, because it is confused by the
new IPROTO_SQL_INFO_* constants, introduced in the tarantool-python
connector in [2].

Part of tarantool/test-run#20
Part of #5652

[1]: tarantool/test-run#264
[2]: tarantool/tarantool-python@9d3573e

(cherry picked from commit fc86213)
Totktonada added a commit to tarantool/tarantool that referenced this pull request Jan 20, 2021
Update the test-run submodule with updating its tarantool-python
submodule with the Response.__str__() change, which unifies behaviour
between Python 2 and Python 3. We lean on this in the
box-py/call.test.py test. See more in [1].

Updated the box-py/iproto.test.py test, because it is confused by the
new IPROTO_SQL_INFO_* constants, introduced in the tarantool-python
connector in [2].

Part of tarantool/test-run#20
Part of #5652

[1]: tarantool/test-run#264
[2]: tarantool/tarantool-python@9d3573e

(cherry picked from commit fc86213)
Totktonada added a commit to tarantool/tarantool that referenced this pull request Jan 20, 2021
Update the test-run submodule with updating its tarantool-python
submodule with the Response.__str__() change, which unifies behaviour
between Python 2 and Python 3. We lean on this in the
box-py/call.test.py test. See more in [1].

Updated the box-py/iproto.test.py test, because it is confused by the
new IPROTO_SQL_INFO_* constants, introduced in the tarantool-python
connector in [2].

Part of tarantool/test-run#20
Part of #5652

[1]: tarantool/test-run#264
[2]: tarantool/tarantool-python@9d3573e

(cherry picked from commit fc86213)
@Totktonada
Copy link
Member Author

Updated the test-run submodule in tarantool in 2.8.0-21-gfc86213cd, 2.7.1-20-g8c07ab317, 2.6.2-19-gb95bb7e8f, 1.10.9-7-gc252616dd.

test/box-py/iproto.test.py requires a tiny update, see the linked commit.

avtikhon pushed a commit to tarantool/tarantool that referenced this pull request Jan 21, 2021
Update the test-run submodule with updating its tarantool-python
submodule with the Response.__str__() change, which unifies behaviour
between Python 2 and Python 3. We lean on this in the
box-py/call.test.py test. See more in [1].

Updated the box-py/iproto.test.py test, because it is confused by the
new IPROTO_SQL_INFO_* constants, introduced in the tarantool-python
connector in [2].

Part of tarantool/test-run#20
Part of #5652

[1]: tarantool/test-run#264
[2]: tarantool/tarantool-python@9d3573e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants