Inappropriate dependency in deb package

[rosik]

Tarantool version: 2.4.2

$ apt show tarantool tarantool-common                                                                                                                                                   
Package: tarantool 
Version: 2.4.2.0.gcccd89701-1
Depends: ..., tarantool-common (>= 1.7.5.46)

Tarantool dependency on tarantool-common from is specified as >= 1.7.5, while it should be == 2.4.2....

The tarantoolctl binary belongs to the tarantool-common package, but all luarocks modules - to the tarantool. Version inconsistency causes problems.

[Totktonada]

The idea of tarantool-common and this weak dependency is to don't update init/service files (and restart the daemon) each time tarantool is updated. AFAIK, it is Debian policy to restart a service at update. AFAIR, we can skip restart by using DEB_DH_SYSTEMD* options. Maybe there were no such ability in the past or the idea was to restart tarantool anyway when the entire system is upgraded (and so tarantool-common is updated too).

In short: the weak dependency is right, but the minimal dependency should be bumped when given tarantoolctl version is not compatible with given tarantool version anymore.

[Totktonada]

The problem per se (reported by a user via @rosik to us):

/usr/bin/tarantoolctl:908: module 'luarocks.cfg' not found

So, we should depend on tarantool-common with tarantoolctl with luarocks-3 support for versions of tarantool, which ship luarocks-3.

[Mons]

Maybe better change shipment unit of luarocks module and move it to tarantoolctl package (common)?

[rosik]

I would also add that tarantoolctl --help reported 2.4.2, while in fact it was installed from 1.10 package, and it's misleading.

[Totktonada]

Maybe better change shipment unit of luarocks module and move it to tarantoolctl package (common)?

Seems good on the first glance.

NB: If we'll do, we should correctly set which packages blocks each others to avoid conflicting by files.

[rosik]

The same issue just affected @Errora

The reason is the old tarantool-common 1.9, apt upgrade fixed it.