Skip to content

Conditional skip for datetime test cases #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DifferentialOrange opened this issue Oct 18, 2022 · 0 comments · Fixed by #297
Closed

Conditional skip for datetime test cases #246

DifferentialOrange opened this issue Oct 18, 2022 · 0 comments · Fixed by #297
Assignees
Labels
code health Improve code readability, simplify maintenance and so on

Comments

@DifferentialOrange
Copy link
Member

There are two tarantool-python + Tarantool integration tests for datetime arithmetic that are skipped for now due to core bugs:

@skip_or_run_datetime_test
@unittest.skip('See https://github.com/tarantool/tarantool/issues/7698')
def test_tarantool_datetime_subtraction_different_timezones(self):
case = self.datetime_subtraction_different_timezones_case
self.assertSequenceEqual(self.con.call('sub', case['arg_1'], case['arg_2']),
[case['res']])

@skip_or_run_datetime_test
@unittest.skip('See https://github.com/tarantool/tarantool/issues/7700')
def test_tarantool_datetime_addition_winter_time_switch(self):
case = self.datetime_addition_winter_time_switch_case
self.assertSequenceEqual(self.con.call('add', case['arg_1'], case['arg_2']),
[case['res']])

This skips should be changed to conditional skips after Tarantool release (now bugs are fixed, but there is no tagged version with fix).

@DifferentialOrange DifferentialOrange added code health Improve code readability, simplify maintenance and so on blocked Not ready to be implemented teamE labels Oct 18, 2022
@DifferentialOrange DifferentialOrange self-assigned this Oct 18, 2022
@DifferentialOrange DifferentialOrange changed the title Uncomment datetime test cases Conditional skip for datetime test cases Oct 18, 2022
@DifferentialOrange DifferentialOrange removed the blocked Not ready to be implemented label Jun 28, 2023
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
There were a couple of datetime bugs in core Tarantool [1, 2] in 2.10
that were fixed in 2.11. We had a couple of test cases which were
skipped before because of these bugs. After 2.11 we may change these
skips to conditional skips.

1. tarantool/tarantool#7698
2. tarantool/tarantool#7700

Closes #246
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
There were a couple of datetime bugs in core Tarantool [1, 2] in 2.10
that were fixed in 2.11. We had a couple of test cases which were
skipped before because of these bugs. After 2.11 we may change these
skips to conditional skips.

1. tarantool/tarantool#7698
2. tarantool/tarantool#7700

Closes #246
DifferentialOrange added a commit that referenced this issue Jun 28, 2023
There were a couple of datetime bugs in core Tarantool [1, 2] in 2.10
that were fixed in 2.11. We had a couple of test cases which were
skipped before because of these bugs. After 2.11 we may change these
skips to conditional skips.

1. tarantool/tarantool#7698
2. tarantool/tarantool#7700

Closes #246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Improve code readability, simplify maintenance and so on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants