Return working tests on php7.0-php7.2 #140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bigbes
commented
Dec 2, 2018
bigbes
commented
- Update test-run.py and lib/tarantool_server.py to support python 3
- Update tests accordingly to new version of PHPUnit
- Added initialization of standart class properties to 'Tarantool'
- Update .travis.yml (remove all junk)
….1+) * Update test-run.py and lib/tarantool_server.py to support python 3 * Update tests accordingly to new version of PHPUnit * Added initialization of standart class properties to 'Tarantool'
bigbes
changed the title
Totktonada
reviewed
Dec 12, 2018
.travis.yml
Outdated
| matrix: | ||
| include: | ||
| - { env: TARGET=test, php: 7.1 } | ||
| - { env: TARGET=test, php: nightly } |
There was a problem hiding this comment.
So only 2 targets will be run. No packaging ones.
There was a problem hiding this comment.
Planned to give packaging back in the scope of #117.
There was a problem hiding this comment.
But anyway need to comment this point in the commit message, so I leave the discussion unresolved for now.
Remove obsolete test-suite config from test-run.py
Totktonada
reviewed
Dec 12, 2018
| if self.script: | ||
| shutil.copy(self.script, self.script_dst) | ||
| os.chmod(self.script_dst, 511) | ||
| os.chmod(self.script_dst, 0o777) |
There was a problem hiding this comment.
Nit: You touched this line 2 times arcoss there commits. 0777 → 511 → 0o777. Please, use 0o777 right in the first commit.
Totktonada
reviewed
Dec 12, 2018
| public function testFoo() | ||
| { | ||
| $tnt = $this->getMock('Tarantool'); | ||
| // $tnt = $this->createMock(['Tarantool']); |
bigbes
force-pushed
the
return-operabiluty
branch
from
d62eb1a to
ef47438
Compare
Merged
|
Superseded by PR #153. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.