Fix NoSuchMethodError when Buffer.clear() is called #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicktorwald
force-pushed
the
highpower/issue-215-fix
branch
from
49447f1 to
a5d441c
Compare
nicktorwald
changed the title
Tarantool client uses java.nio.ByteBuffer to represent a payload to be sent through the network. JDK 9 introduces a number of new methods that override java.nio.Buffer methods in order to return ByteBuffer instead of Buffer. Because of overriding, those methods are available in JRE 8 or below but cannot be invoked if the connector is built using JDK 9 or above using new signatures for methods overridden. To be compatible with JREs before 9, it possible to cast ByteBuffer to Buffer class explicitly. As a result, a method will be called which is available in older versions but it breaks conciseness of the code. Closes: #215
nicktorwald
force-pushed
the
highpower/issue-215-fix
branch
from
a5d441c to
43d72df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tarantool client uses java.nio.ByteBuffer to represent a payload to be
sent through the network. JDK 9 introduces a number of new methods that
override java.nio.Buffer methods in order to return ByteBuffer instead
of Buffer. Because of overriding, those methods are available in JRE 8
or below but cannot be invoked if the connector is built using JDK 9 or
above using new signatures for methods overridden. To be compatible
with JREs before 9, it possible to cast ByteBuffer to Buffer class
explicitly. As a result, a method will be called which is available in
older versions but it breaks conciseness of the code.
Closes: #215