Update tarantool if there is more fresh version #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Totktonada
reviewed
Feb 6, 2021
Contributor
|
As I see, the 'Setup from cache' step in CI has more or less same timing as before. It was 2-4 seconds and here we see 2-4 seconds. That's nice! |
Totktonada
approved these changes
Feb 6, 2021
Contributor
Totktonada
left a comment
Totktonada
left a comment
There was a problem hiding this comment.
The logic looks good. (I didn't test it, just glanced over the changed code.)
No objections from me.
rosik
force-pushed
the
9-keep-updating
branch
6 times, most recently
from
732abb6 to
b9fa7f1
Compare
Contributor
Author
|
I've reorganized the code. It was necessary for adding a test. Re-approve please |
Totktonada
reviewed
Feb 10, 2021
Totktonada
reviewed
Feb 10, 2021
Totktonada
approved these changes
Feb 10, 2021
Contributor
Totktonada
left a comment
Totktonada
left a comment
There was a problem hiding this comment.
No objections from my side.
rosik
force-pushed
the
9-keep-updating
branch
from
b9fa7f1 to
b7589b7
Compare
Once a version is installed it's cached. A user could drop the cache
manually (by updating cache-key), but it should be automated.
This patch changes the caching logics. The 'cache-key' input is
deprecated. Instead, it includes precise deb package version which is
obtained by parsing repo content manually:
```js
http_get("https://download.tarantool.org/tarantool/release/2.6" +
"/ubuntu/dists/focal/main/binary-amd64/Packages"
)
```
It doesn't waste too much time and allows us to reinstall tarantool from
apt-get when the new verison is out.
Resulting key looks like
```txt
tarantool-setup-focal-2.8.0.0.gefc30ccf8-1
```
rosik
force-pushed
the
9-keep-updating
branch
from
b7589b7 to
3defc67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch resolves the problem described in #9 (comment).
Once a version is installed it's cached. A user could drop the cache manually (by updating the
cache-key), but it should be automated.This patch changes the caching logic. The
cache-keyinput is deprecated. Instead, it's generated and includes a precise deb package version which is obtained by parsing repo content manually:It doesn't waste too much time and allows us to reinstall tarantool from apt-get when the new version is out.
The resulting
cache-keylooks liketarantool-setup-focal-2.8.0.0.gefc30ccf8-1.