Skip to content

Fix cartridge issues metric call before cartridge.cfg() #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 10, 2021
Merged

Fix cartridge issues metric call before cartridge.cfg() #299

merged 3 commits into from
Sep 10, 2021

Conversation

yngvar-antonsson
Copy link
Contributor

@yngvar-antonsson yngvar-antonsson commented Sep 9, 2021 •
edited
Loading

Before cartridge.cfg() call list_on_instance throw an error. I pcall it.

I didn't forget about

  • Tests
  • Changelog

Close #298

DifferentialOrange
DifferentialOrange approved these changes Sep 10, 2021
View reviewed changes
@yngvar-antonsson yngvar-antonsson merged commit 7652824 into master Sep 10, 2021
@yngvar-antonsson yngvar-antonsson deleted the cartridge-issues branch September 10, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DifferentialOrange DifferentialOrange DifferentialOrange approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stateboard instance fails to collect cartridge issues
2 participants
@yngvar-antonsson @DifferentialOrange