Skip to content

readme: describe how to run tests #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2022
Merged

readme: describe how to run tests #139

merged 1 commit into from
Feb 14, 2022

Conversation

DifferentialOrange
Copy link
Member

@DifferentialOrange DifferentialOrange commented Jan 17, 2022 •
edited
Loading

Prerequirements: merging #137 (there is no need to describe environment preparation if it is handled automatically).

Describe how to run connector tests (with submodules) and test requirements.

Closes #106

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from 526b4a7 to 5f206c7 Compare January 17, 2022 15:24
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from 5f206c7 to 7a2f1cc Compare January 18, 2022 11:17
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-107-self-sufficing-tests branch from 510da5f to 45def97 Compare January 31, 2022 08:30
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from 7a2f1cc to 7f26ec4 Compare January 31, 2022 08:30
LeonidVas
LeonidVas reviewed Jan 31, 2022
View reviewed changes
Copy link

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patch. Generally ok.
I suggest to returning to it after the #137 is merged, because it may affect this patch.

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-107-self-sufficing-tests branch 2 times, most recently from 413bef4 to bc75d65 Compare January 31, 2022 16:21
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from 7f26ec4 to f158a3b Compare January 31, 2022 16:27
LeonidVas
LeonidVas reviewed Feb 1, 2022
View reviewed changes
LeonidVas
LeonidVas approved these changes Feb 1, 2022
View reviewed changes
Copy link

@LeonidVas LeonidVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thank you for the patch.
Am I correct in assuming that we can't run all the tests at once now and have to go through the subpackages to run their tests?

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-107-self-sufficing-tests branch from bc75d65 to cc58bf1 Compare February 1, 2022 12:52
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from f158a3b to 6240fa8 Compare February 1, 2022 12:53
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-107-self-sufficing-tests branch from cc58bf1 to b6f8631 Compare February 1, 2022 13:05
@DifferentialOrange
Copy link
Member Author

DifferentialOrange commented Feb 1, 2022 •
edited
Loading

Am I correct in assuming that we can't run all the tests at once now and have to go through the subpackages to run their tests?

Oh, that's a good question! For some reason I forget to check this possibility, but it seems like you can run them with go test -p 1 ./... (-p 1 disables running tests in parallel) now or even run them with go test ./... if we set different port for each test tarantool.

I'll definitely make some improvements to #137 and rework this PR

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-107-self-sufficing-tests branch from b6f8631 to 8314aa6 Compare February 1, 2022 16:06
@DifferentialOrange DifferentialOrange mentioned this pull request Feb 1, 2022
Merged
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-107-self-sufficing-tests branch 4 times, most recently from f5ef71d to 922321c Compare February 2, 2022 08:47
@ligurio
Copy link
Member

ligurio commented Feb 3, 2022

@DifferentialOrange please fix conflicts

ligurio
ligurio requested changes Feb 3, 2022
View reviewed changes
@DifferentialOrange
Copy link
Member Author

@DifferentialOrange please fix conflicts

Sorry, I forgot to rebase the branch after last change in #137

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-107-self-sufficing-tests branch from 922321c to 491e9aa Compare February 3, 2022 16:17
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from 6240fa8 to ad7fdf8 Compare February 3, 2022 16:18
@DifferentialOrange
Copy link
Member Author

I commited and pushed all changes related to #137 updates

ligurio
ligurio requested changes Feb 7, 2022
View reviewed changes
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from ad7fdf8 to e3ce790 Compare February 7, 2022 07:20
@ligurio ligurio self-requested a review February 8, 2022 11:16
ligurio
ligurio approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@ligurio ligurio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vr009
vr009 approved these changes Feb 8, 2022
View reviewed changes
Copy link

@vr009 vr009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-107-self-sufficing-tests branch from aa80991 to bd1263f Compare February 8, 2022 11:44
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from e3ce790 to 8d24a5b Compare February 8, 2022 11:46
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-107-self-sufficing-tests branch from bd1263f to 861a33f Compare February 14, 2022 16:26
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from 8d24a5b to e4c8da6 Compare February 14, 2022 16:26
Base automatically changed from DifferentialOrange/gh-107-self-sufficing-tests to master February 14, 2022 16:28
@DifferentialOrange
readme: describe how to run tests
4921aff 
Describe how to run connector tests (with submodules) and
test requirements.

Closes #106
@DifferentialOrange DifferentialOrange force-pushed the DifferentialOrange/gh-106-test-run branch from e4c8da6 to 4921aff Compare February 14, 2022 16:29
@DifferentialOrange DifferentialOrange merged commit b2a3b71 into master Feb 14, 2022
@DifferentialOrange DifferentialOrange deleted the DifferentialOrange/gh-106-test-run branch February 14, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ligurio ligurio ligurio approved these changes

@vr009 vr009 vr009 approved these changes

@LeonidVas LeonidVas LeonidVas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test run entry to README
4 participants
@DifferentialOrange @ligurio @vr009 @LeonidVas