Skip to content

pool: ability to add/remove an endpoint #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oleg-jukovec opened this issue May 11, 2023 · 0 comments · Fixed by #297
Closed

pool: ability to add/remove an endpoint #290

oleg-jukovec opened this issue May 11, 2023 · 0 comments · Fixed by #297
Assignees
@oleg-jukovec
Labels
feature A new functionality teamE

Comments

@oleg-jukovec
Copy link
Collaborator

oleg-jukovec commented May 11, 2023 •
edited
Loading

Users need additional methods in ConnectionPool to add and remove endpoints.

An endpoint should be added after a successful connection.
A connection should be gracefully removed from a pool. It is connected with #257 .

The feature requested by @ochaton .
@oleg-jukovec oleg-jukovec added feature A new functionality 3sp labels May 11, 2023
@oleg-jukovec oleg-jukovec changed the title pool: ability to add/remove endpoint pool: ability to add/remove an endpoint May 11, 2023
@oleg-jukovec oleg-jukovec self-assigned this May 24, 2023
@oleg-jukovec oleg-jukovec mentioned this issue May 26, 2023
Merged
3 tasks
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
api: ConnectionPool.Add()/ConnectionPool.Remove()
102dfd8 
* ConnectionPool.Add() allows to add a new endpoint into a pool.
* ConnectionPool.Remove() allows to remove an endpoint from a pool.

Closes #290
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
api: ConnectionPool.Add()/ConnectionPool.Remove()
852a31b 
* ConnectionPool.Add() allows to add a new endpoint into a pool.
* ConnectionPool.Remove() allows to remove an endpoint from a pool.

Closes #290
@oleg-jukovec oleg-jukovec mentioned this issue May 29, 2023
Merged
3 tasks
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
Release 1.12.0
59a709b 
Overview

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
Release 1.12.0
9fb0943 
Overview

The release introduces the ability to gracefully close Connection
and ConnectionPool and also provides methods for adding or removing
an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
Release 1.12.0
238562f 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
@oleg-jukovec oleg-jukovec mentioned this issue May 29, 2023
Merged
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
api: ConnectionPool.Add()/ConnectionPool.Remove()
430da00 
* ConnectionPool.Add() allows to add a new endpoint into a pool.
* ConnectionPool.Remove() allows to remove an endpoint from a pool.

Closes #290
oleg-jukovec added a commit that referenced this issue Jun 5, 2023
@oleg-jukovec
api: ConnectionPool.Add()/ConnectionPool.Remove()
2acfb5a 
* ConnectionPool.Add() allows to add a new endpoint into a pool.
* ConnectionPool.Remove() allows to remove an endpoint from a pool.

Closes #290
oleg-jukovec added a commit that referenced this issue Jun 5, 2023
@oleg-jukovec
api: ConnectionPool.Add()/ConnectionPool.Remove()
c810cb3 
* ConnectionPool.Add() allows to add a new endpoint into a pool.
* ConnectionPool.Remove() allows to remove an endpoint from a pool.

Closes #290
oleg-jukovec added a commit that referenced this issue Jun 6, 2023
@oleg-jukovec
Release 1.12.0
5fff2f0 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue Jun 7, 2023
@oleg-jukovec
Release 1.12.0
1d2d5cd 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue Jun 7, 2023
@oleg-jukovec
Release 1.12.0
403f2c3 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleg-jukovec oleg-jukovec

Labels
feature A new functionality teamE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: ConnectionPool.Add()/ConnectionPool.Remove() tarantool/go-tarantool
2 participants
@oleg-jukovec @LeonidVas