Skip to content

document 'memtx_allocator' and 'slab_alloc_granularity' #3355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 27, 2023
Merged

document 'memtx_allocator' and 'slab_alloc_granularity' #3355

merged 6 commits into from
Feb 27, 2023

Conversation

andreyaksenov
Copy link
Contributor

@andreyaksenov andreyaksenov commented Feb 21, 2023 •
edited
Loading

Add reference docs for the memtx_allocator and slab_alloc_granularity options.

Resolves #2291 #1911

@veod32 veod32 linked an issue Feb 22, 2023 that may be closed by this pull request
[3pt] Add 'slab_alloc_granularity' option to box.cfg{} #1911
Closed
@andreyaksenov andreyaksenov requested a review from p7nov February 22, 2023 11:44
p7nov
p7nov approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@p7nov p7nov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally OK, just a few comments from my side.

doc/reference/configuration/cfg_storage.rst Outdated

Since version :doc:`2.8.1 </release/2.8.1>`.
Specifies the granularity of memory allocation in the :ref:`small allocator <cfg_storage-memtx_allocator>`.
The value of ``slab_alloc_granularity`` should be a power of two and should greater than or equal to 4.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The value of ``slab_alloc_granularity`` should be a power of two and should greater than or equal to 4.
The value of ``slab_alloc_granularity`` should be a power of two and should be greater than or equal to 4.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, is this value an actual memory size in some units or an abstract parameter?
In the first case, we should mention the unit in this description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, @alyapunov could you please clarify regarding this question?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is measured in bytes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@Mons Mons self-requested a review February 27, 2023 12:55
@andreyaksenov andreyaksenov merged commit 2c2fd3d into latest Feb 27, 2023
@andreyaksenov andreyaksenov deleted the configuring-storage branch February 27, 2023 13:00
p7nov pushed a commit that referenced this pull request Mar 24, 2023
@andreyaksenov @p7nov
document 'memtx_allocator' and 'slab_alloc_granularity' (#3355)
bb54244 
Add reference docs for the `memtx_allocator` and `slab_alloc_granularity` options.

Resolves #2291 
Resolves #1911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gumix Gumix Gumix left review comments

@Mons Mons Mons approved these changes

@alyapunov alyapunov alyapunov approved these changes

@p7nov p7nov p7nov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[2pt] Add new 'memtx_allocator' option to box.cfg{} [3pt] Add 'slab_alloc_granularity' option to box.cfg{}
5 participants
@andreyaksenov @Mons @alyapunov @Gumix @p7nov