Clarify trigger event context #2965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Korablev77
reviewed
Jun 24, 2022
doc/book/box/triggers.rst
Outdated
| from it (such as `os.exit() <http://www.lua.org/manual/5.1/manual.html#pdf-os.exit>`_ | ||
| or :doc:`/reference/reference_lua/box_txn_management/rollback`), the behavior | ||
| is undefined. | ||
| * Triggers must work within the event context. This means that their functions |
There was a problem hiding this comment.
their functions
Я думаю правильнее говорить тело функции и/или реализация: "... their implementation should not...". Или "This means that function implementing trigger".
event context
Я так понимаю основной вопрос был здесь: не совсем понятно что это. Я бы написал, что тут не стоит изменять глобальное состояние программы, то есть работать только с переменными, которые передаются в сам триггер.
There was a problem hiding this comment.
Thanks for clarification. Rephrased the text.
Korablev77
approved these changes
Jun 28, 2022
|
Вроде ок, но я бы еще кому-то дал почитать |
Co-authored-by: Dia Patience Daur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rephrase paragraph about event context in Triggers for better understanding (feedback in #2538).
Resolves #2538