Document vshard.router.map_callrw()
#2753
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuniq
force-pushed
the
gh-2015-map-reduce
branch
from
75bb124 to
c3fc636
Compare
xuniq
force-pushed
the
gh-2015-map-reduce
branch
from
293d139 to
e961bdc
Compare
veod32
requested changes
Mar 29, 2022
|
|
||
| The chosen function is called on the master node of each replicaset with the given arguments. | ||
|
|
||
| :param function_name: a function to call on the storages |
There was a problem hiding this comment.
storages — instances with the vshard role "storage" ? Can you think of another wording for that (here and further)?
There was a problem hiding this comment.
Storages in this context means "masters of all replicasets". But you normally should think of them as just "storages" or "replicasets". Not about individual nodes.
Gerold103
reviewed
Mar 29, 2022
|
|
||
| The chosen function is called on the master node of each replicaset with the given arguments. | ||
|
|
||
| :param function_name: a function to call on the storages |
There was a problem hiding this comment.
Storages in this context means "masters of all replicasets". But you normally should think of them as just "storages" or "replicasets". Not about individual nodes.
xuniq
force-pushed
the
gh-2015-map-reduce
branch
from
ca20439 to
1578869
Compare
veod32
reviewed
Apr 12, 2022
veod32
approved these changes
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2015
Deploy (API Reference): https://develop.tarantool.io/en/doc/gh-2015-map-reduce/reference/reference_rock/vshard/vshard_api/
Deploy (map_callrw()): https://develop.tarantool.io/en/doc/gh-2015-map-reduce/reference/reference_rock/vshard/vshard-router/#lua-function.vshard.router.map_callrw