Skip to content

fixes gh-1905 actualise building_from_source.rst #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 7, 2021
Merged

Conversation

Onvember
Copy link
Contributor

@Onvember Onvember commented Mar 25, 2021

@github-actions github-actions bot temporarily deployed to release March 25, 2021 14:35 Inactive
@github-actions github-actions bot temporarily deployed to release March 26, 2021 07:44 Inactive
@github-actions github-actions bot temporarily deployed to release March 26, 2021 07:58 Inactive
@Totktonada
Copy link
Member

(The link to the test server gives me infinite redirect after authorization.)

To be honest, this page scaries me. (My feeling: should I read all this text just to build tarantool?!)

Can we split it to sections?

  • A short 'common path to build & test'. Not much text, mostly commands. (I would also think how to better visualize OS specific steps to ease skipping of unrelated parts. Subsections?)
  • Recipes: 'How to clean up the repo?', 'How to build tarantoolctl?', 'How to install tarantool?', 'How to set a build type?', 'How to build a package?' and so on.
  • Troubleshooting (I'll not look to the section if everything goes fine).

I see, a lot of work is performed to actualize the instructions.

However there are notes and recipes that does not look actual (or it is unclear whether the problem still actual, it is not clear where it may appear). When we need to install PyYAML from sources (especially 3.10, which is very old)? On which OSes we need to install openssl111 (if it is for FreeBSD, then FreeBSD 12 and 13 already have 1.1.1 version in the openssl package).

Maybe it is good time to get rid of old troubleshooting recipes. New ones should be accompanied with a clear description of the problem and should bring all necessary context.

@github-actions github-actions bot temporarily deployed to branch-gh-1905 April 2, 2021 07:49 Inactive
@Onvember
Copy link
Contributor Author

Onvember commented Apr 2, 2021

The new version is based on @Totktonada suggestions and recommendations. I managed to check all these instructions, except FreeBSD. I found two bugs while building (tarantool/tarantool#5959 and tarantool/tarantool#5955).

Copy link
Member

@Totktonada Totktonada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside of several small comments the PR is okay for me. I think it is nice simplification of the document structure.

I think there is no need to review it again with me if there are no questions or doubts regarding my comments.

@github-actions github-actions bot temporarily deployed to branch-gh-1905 April 7, 2021 09:41 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants