Skip to content

[3pt] feedback: Module net.box | Poor example #2271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
TarantoolBot opened this issue Aug 4, 2021 · 0 comments · Fixed by #3186
Closed

[3pt] feedback: Module net.box | Poor example #2271

TarantoolBot opened this issue Aug 4, 2021 · 0 comments · Fixed by #3186
Assignees
@xuniq
Labels
example Problem with a code example. reference [location] Tarantool manual, Reference part rewrite [nature] Revise existing text for structure/phrasing/terms server [area] Task relates to Tarantool's server (core) functionality

Comments

@TarantoolBot
Copy link
Collaborator

TarantoolBot commented Aug 4, 2021 •
edited by xuniq
Loading

Check the example in module net.box

Product: Tarantool
Root document: https://www.tarantool.io/en/doc/latest/reference/reference_lua/net_box/#net-box-on-connect
SME: @ Gerold103, @ locker
Peer reviewer: @

Details

<…>.schema.user.grant('guest', 'read,write,execute', 'universe')

|And here starts the example|:
COPYnet_box = require('net.box')
function example()
local co<…>

https://www.tarantool.io/en/doc/latest/reference/reference_lua/net_box/#net-box-on-connect

очень плохой пример, ничего не понятно
зачем таблица ta?
почему внутри функции не делать print?
@xuniq xuniq added this to the Estimate [@xuniq] milestone Aug 23, 2021
@xuniq xuniq added reference [location] Tarantool manual, Reference part factual error Factual error in functionality description rewrite server [area] Task relates to Tarantool's server (core) functionality and removed factual error Factual error in functionality description labels Sep 1, 2021
@xuniq xuniq changed the title feedback: Module net.box | Tarantool [3pt] feedback: Module net.box | Tarantool Sep 1, 2021
@xuniq xuniq removed this from the Estimate [@xuniq] milestone Sep 1, 2021
@xuniq xuniq added rewrite [nature] Revise existing text for structure/phrasing/terms and removed rewrite labels Sep 1, 2021
@patiencedaur patiencedaur mentioned this issue Feb 1, 2022
Open
26 tasks
@patiencedaur patiencedaur changed the title [3pt] feedback: Module net.box | Tarantool [3pt] feedback: Module net.box | Poor example Feb 28, 2022
@patiencedaur patiencedaur added the example Problem with a code example. label Feb 28, 2022
@xuniq xuniq self-assigned this Oct 6, 2022
@xuniq xuniq added the unplanned label Oct 6, 2022
@veod32 veod32 removed the unplanned label Oct 10, 2022
@xuniq xuniq mentioned this issue Oct 11, 2022
Merged
@veod32 veod32 added 1sp and removed 3sp labels Oct 12, 2022
xuniq added a commit that referenced this issue Oct 18, 2022
@xuniq
Update the example in module net.box (#3186)
948adeb 
Fixes #2271 

* Rewrite the example
* Move text to how-to section
* Translate page, update translation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xuniq xuniq

Labels
example Problem with a code example. reference [location] Tarantool manual, Reference part rewrite [nature] Revise existing text for structure/phrasing/terms server [area] Task relates to Tarantool's server (core) functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the example in module net.box tarantool/doc
4 participants
@TarantoolBot @patiencedaur @veod32 @xuniq