Skip to content

Fixed select crash when dropping indexes. #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jan 25, 2021
Merged

Fixed select crash when dropping indexes. #108

merged 10 commits into from
Jan 25, 2021

Conversation

mRrvz
Copy link
Contributor

@mRrvz mRrvz commented Jan 20, 2021 •
edited
Loading

Fixed selection error when dropping indexes by replacing the # operator with a call to table.maxn when creating a select plan.

Closes #103.

olegrok
olegrok reviewed Jan 21, 2021
View reviewed changes
dokshina
dokshina reviewed Jan 21, 2021
View reviewed changes
dokshina
dokshina reviewed Jan 21, 2021
View reviewed changes
olegrok
olegrok reviewed Jan 22, 2021
View reviewed changes
dokshina
dokshina reviewed Jan 22, 2021
View reviewed changes
dokshina
dokshina reviewed Jan 22, 2021
View reviewed changes
dokshina
dokshina reviewed Jan 25, 2021
View reviewed changes
dokshina
dokshina reviewed Jan 25, 2021
View reviewed changes
olegrok
olegrok reviewed Jan 25, 2021
View reviewed changes
@dokshina
Copy link
Contributor

Thanks a lot for your patch! Please, update Changelog.

I would like you to make your comment about why do we use table.maxn more clear (probably add an example). And since we have 2 places where it's used, we need two comments. Think about people who will read this code sometimes - they should understand it without suffering.

@mRrvz mRrvz changed the title Fix select crash when dropping indexes Fixed select crash when dropping indexes. Jan 25, 2021
@mRrvz mRrvz force-pushed the fix-select-with-sparsed-array branch from 1af93b1 to ccef78c Compare January 25, 2021 15:04
@dokshina dokshina merged commit 3c4fb44 into master Jan 25, 2021
@dokshina dokshina deleted the fix-select-with-sparsed-array branch January 25, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olegrok olegrok olegrok left review comments

+1 more reviewer

@dokshina dokshina dokshina approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1pt] Select could fail in case of sparsed indexes array
3 participants
@mRrvz @dokshina @olegrok