Fix race condition when serializing the write task closure #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Highly loaded and concurrent Spark environment produced some strange OptionalDataException errors when deserializing the write tasks. That appeared to be a problem with an object that is changed concurrently while being serialized, thus resulting in corrupted serialized data. Using some deduction and exclusion, it became clear that the object with such race condition is the mapper, which is apparently changed by different threads using the same RDD for different Tarantool spaces. With this patch it is not more possible to use a custom mapper, but the proper implementation of that feature needs now fixing the mapper race condition possibility in the driver and re-implementing passing the mapper without implicits.
The latest netty and driver versions introduced a dependency conflict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object with race condition was the tuple mapper, which is apparently changed by
different threads using the same RDD for different Tarantool spaces.
With this patch, it will be not more possible to use a custom mapper, but the
proper implementation of that feature needs now fixing the mapper race
condition possibility in the driver and re-implementing passing the
mapper without implicits.
May be related:
Fixes #45