Add can convert value to TupleResultConverter #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akudiyar
requested changes
Mar 27, 2023
There was a problem hiding this comment.
TarantoolResult is only about tuples. It's a special container class and it is necessary to distinct an array of arrays as tuples from an array of arrays that are not tuples or an array of any other objects (e.g. maps).
Would you mind explaining a bit more how this change will solve the original problem?
Co-authored-by: Alexey Kuzin <[email protected]>
akudiyar
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's needed when we want to take maps in the array. Springdata can map map structures. Using AUTO converter we can't map a simple array without tuples to the array and pass conversion control to the next layer.
I haven't forgotten about:
Related issues:
Needed for tarantool/cartridge-springdata#123