-
Notifications
You must be signed in to change notification settings - Fork 13
Refactoring for RequestRetryPolicies and classes in exceptions.errors package #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9d5ed75 to
10880f7
Compare
src/main/java/io/tarantool/driver/exceptions/errors/TarantoolErrors.java
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/exceptions/TarantoolNoSuchProcedureException.java
Outdated
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/exceptions/TarantoolNoSuchProcedureException.java
Outdated
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/exceptions/errors/ErrorsErrorKey.java
Outdated
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/exceptions/errors/TarantoolErrorsParser.java
Show resolved
Hide resolved
Co-authored-by: Vladimir Rogach <[email protected]>
akudiyar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, but IT tests need more consideration.
src/main/java/io/tarantool/driver/exceptions/errors/TarantoolErrorsParser.java
Show resolved
Hide resolved
|
@wey1and please do not forget to include backwards compatibility changes into changelog |
|
nit: One commit is expected before the merge with a full description for a simplified review and a clean commit history. |
src/main/java/io/tarantool/driver/api/retry/TarantoolRequestRetryPolicies.java
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/exceptions/TarantoolNoSuchProcedureException.java
Outdated
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/exceptions/TarantoolNoSuchProcedureException.java
Outdated
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/exceptions/TarantoolNoSuchProcedureException.java
Outdated
Show resolved
Hide resolved
src/main/java/io/tarantool/driver/exceptions/errors/TarantoolErrors.java
Outdated
Show resolved
Hide resolved
|
nit: The PR title does not reveal what is in the PR. It seems better not to use the word refactoring, because there was not only a refactoring, but also changes in API of the Just this will be a generalized version of what is happening in PR. And in the description, you can just write that a refactoring has taken place, the API has changed and a new exception has been added and why it was added. And I expect to see this also in the final squashed commit message. |
ArtDu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/test/java/io/tarantool/driver/integration/ProxyTarantoolClientIT.java
Show resolved
Hide resolved
akudiyar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
BTW there is a truncate_space() test failing on 1.10 -- we need to fix it.
… package (#162) Added TarantoolNoSuchProcedureException and refactored TarantoolErrors for parsing errors from MsgPack maps
Added refactoring for RequestRetryPolicies and classes in
exceptions.errorspackageAdded new Exception called
TarantoolNoSuchProcedureExceptionfor this message, so that the user can specify it in the retry policyCloses #159