feat: throw when theme does not have requested path #1799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
friendly ping |
|
Thanks @jquense! Going to merge this then look at making some some additions to provide error messages similar to those in the VS Code extension (e.g. |
adamwathan
pushed a commit
that referenced
this pull request
Oct 19, 2020
* feat: throw when theme does not have requested path (#1799) * Add suggestions to theme function errors Co-authored-by: Jason Quense <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick attempt to fail more loudly when
theme()misses a property. Error messages could probably use some copy editing.Also b/c postcss-functions doesn't expose the current node, it's awkward to throw and error, and it's less helpful than it could be pointing to the file instead of the location that is busted.
closes #1797