Add support for explicit content path via @content
#14048
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
feat/content-path
branch
4 times, most recently
from
89b7854 to
2c8a3c0
Compare
This currently only scans files that we resolved when scanning for globs. This does not register globs themselves, so if a new file is added it won't trigger a rebuild (even if it matches the globs).
We will test auto content _and_ globs from now on.
This is currently necessary so that we don't run into issues where the cache is shared. Maybe a better solution is to turn off caching for certain tests somehow.
+ remove `scan_glob` because it's part of `scanDir` now
We put it in for consistency with `output_globs`, but we actually don't use it so let's get rid of it entirely.
If a glob starts with `./`, `../` or normal strings like `*.ts`, then we have to prepend the base path. However, if a glob is an absolute pattern such as `/Users/tailwind/dev/project/**/*.html`, then we don't have to prepend the base path. This is useful for when we are working with `@content`, and we can prepend the location of the current file to the glob. That way it will already be scoped to the correct location.
RobinMalfait
force-pushed
the
feat/content-path
branch
from
2c8a3c0 to
662cc6f
Compare
|
Closed in favor of: #14079 |
RobinMalfait
added a commit
that referenced
this pull request
Aug 5, 2024
This is a continuation of #14048 where we specifically focus on the `@tailwindcss/cli`. This PR optimizes the globs such that we always have a clean `base` and the `glob` (which is the first dynamic part). This PR also refactors the CLI such that we can watch files defined by the `@content` at-rules in the CSS. The `@parcel/watcher` watches from a base path (not a glob), which means that we have to create a watcher for each glob's base. This PR also adds a `scanFiles` to the `scanDir` result, so that we can verify that a scanned file matches the globs we already know from `scanDir`. Co-authored-by: Philipp Spiess <[email protected]>
philipp-spiess
added a commit
that referenced
this pull request
Aug 5, 2024
This is a continuation of #14048 where we specifically focus on the `@tailwindcss/cli`. This PR optimizes the globs such that we always have a clean `base` and the `glob` (which is the first dynamic part). This PR also refactors the CLI such that we can watch files defined by the `@content` at-rules in the CSS. The `@parcel/watcher` watches from a base path (not a glob), which means that we have to create a watcher for each glob's base. This PR also adds a `scanFiles` to the `scanDir` result, so that we can verify that a scanned file matches the globs we already know from `scanDir`. Co-authored-by: Philipp Spiess <[email protected]>
RobinMalfait
added a commit
that referenced
this pull request
Aug 7, 2024
This is a continuation of #14048 where we specifically focus on the `@tailwindcss/cli`. This PR optimizes the globs such that we always have a clean `base` and the `glob` (which is the first dynamic part). This PR also refactors the CLI such that we can watch files defined by the `@content` at-rules in the CSS. The `@parcel/watcher` watches from a base path (not a glob), which means that we have to create a watcher for each glob's base. This PR also adds a `scanFiles` to the `scanDir` result, so that we can verify that a scanned file matches the globs we already know from `scanDir`. Co-authored-by: Philipp Spiess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.