Skip to content

Conversation

kari-ts
Copy link
Collaborator

@kari-ts kari-ts commented May 8, 2025

&& takes precedence over ?:, so fix isExitNode to check both IPv4 and IPv6

Updates tailscale/tailscale#15785

&& takes precedence over ?:, so fix isExitNode to check both IPv4 and IPv6

Updates tailscale/tailscale#15785

Signed-off-by: kari-ts <[email protected]>
@ghost
Copy link

ghost commented May 8, 2025

Pull Request Revisions

RevisionDescription
r1
Fixed exit node boolean logicCorrected isExitNode calculation by adding parentheses to ensure proper boolean evaluation

✅ AI review completed for r1
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at [email protected].

@kari-ts kari-ts requested a review from nickoneill May 8, 2025 23:55
@kari-ts kari-ts merged commit e3c76eb into main May 20, 2025
5 checks passed
@kari-ts kari-ts deleted the kari/oop branch May 20, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants