android: bump OSS #645
Merged
android: bump OSS #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OSS and Version updated to 1.83.190-tfd263adc1-g5b4eff216 Signed-off-by: Jonathan Nobels <[email protected]>
Pull Request Revisions
✅ AI review completed for r1 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at [email protected]. |
ghost
reviewed
May 7, 2025
Comment on lines
+322
to
+324
| if ext, ok := ipnlocal.GetExt[*taildrop.Extension](lb); ok { | ||
| ext.SetDirectFileRoot(directFileRoot) | ||
| } |
There was a problem hiding this comment.
In libtailscale/backend.go, consider adding an error log when ipnlocal.GetExt fails to get the taildrop extension. The current implementation silently ignores the case where the extension isn't available, which could make debugging difficult if there are issues with file sharing functionality.
kari-ts
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSS and Version updated to 1.83.190-tfd263adc1-g5b4eff216