-
Notifications
You must be signed in to change notification settings - Fork 447
Document the datasources.update_hyper_data method
#893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the datasources.update_hyper_data method
#893
Conversation
16cd8fd to
f27fd9d
Compare
f27fd9d to
f9b7b26
Compare
f9b7b26 to
99cfa09
Compare
|
lgtm, @dzucker-tab might want to skim it |
|
@vogelsgesang this looks good. Couple of minor things I would change for consistency with other methods: For the docs link, suggest linking into the rest_api_ref.htm section directly: Update Data in Hyper Data Source Because this is new, add a Version section before Parameters explaining where it's available: Version With those changes I can time merging this when the next release happens. |
99cfa09 to
730a72c
Compare
Afaict, this is only in version 3.13. At least that's what the code in TSC currently states...
Is there already a timeline for the next release? |
|
two more comments from @dzucker-tab (accidentally posted directly on the commit, and not in the pull request):
We can still rename this as there was no release, yet. @jonas-eckhardt any preference re
I think we should not tell customers to use a DataSourceItem for data sources with a single connection. Such a wording might even incentivize customers to think: "Hm... I have a ConnectionItem which I want to update. Let's check how many connections the corresponding datasource has. Since if it has only one, I should use the DataSourceItem instead of the ConnectionItem." Why do you think we should change this from its current formulation? I think there might be a solution which addresses both your and my concerns, but I am not sure which formulation that is because I currently don't understand your concern with the docs currently in review |
No but we're aiming for this week or next. |
730a72c to
9b45981
Compare
|
RE:
Advocating for this for the same reason as the REST API reference labelling - to differentiate the type of data being updated as it could be referring to any of several things. RE:
I take your point. Instead, how about:
|
9b45981 to
f47d2cb
Compare
|
renamed the method from
Do our users know what a connection LUID is? and that the difference between |
how about this? datasource_or_connection_item | Either a DataSourceItem or a ConnectionItem. You can use a DatasourceItem if the data source has only a single connection. In all other cases, you must use a ConnectionItem. |
As suggested by @dzucker-tab in #893
datasources.update_data methoddatasources.update_hyper_data method
|
@jacalata RE:
I started with something close to this, Adrian was concerned that it amounted to pushing folks to use @vogelsgesang RE:
IMO, if folks don't know what a LUID is, they should find out, but if that is a stopper, how about:
|
Adds the documentation for the
datasources.update_datamethod added in PR #891