Skip to content

Conversation

@shinchris
Copy link
Contributor

Doc updates go with #794

Adds the new fields in there, as well as a new update endpoint.
The example code snippet shows all the fields you can set for the create and update methods.

@shinchris shinchris changed the title Updates documentation for subscriptions [Docs] Updates documentation for subscriptions Feb 12, 2021
Copy link
Contributor

@bcantoni bcantoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comparing this to the matching code changes, it looks like SubscriptionItem does not actually have schedule_name or user_name, just the "_id" for each of those. Am I missing something or should they be dropped from the list here?

@shinchris
Copy link
Contributor Author

Ah yes, schedule_name and user_name were removed after making this doc PR, as per review feedback. Will update this PR.

@jacalata jacalata merged commit d19d894 into gh-pages Jun 24, 2021
@bcantoni bcantoni deleted the subscription_794 branch June 24, 2021 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants