Skip to content

Improve debug logging by including put/post request contents (limited to first 1000 chars) #743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bcantoni merged 2 commits into from
Dec 3, 2020
Merged

Improve debug logging by including put/post request contents (limited to first 1000 chars) #743

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef95e53
Improve debug logging
bcantoni Nov 20, 2020
0aca85b
Limit request content to 1000 bytes, remove redundant response logging
bcantoni Dec 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tableauserverclient/server/endpoint/endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,19 +50,22 @@ def _make_request(self, method, url, content=None, request_object=None,
if content is not None:
parameters['data'] = content

logger.debug(u'request {}, url: {}'.format(method.__name__, url))
if content:
logger.debug(u'request content: {}'.format(content[:1000]))

server_response = method(url, **parameters)
self.parent_srv._namespace.detect(server_response.content)
self._check_status(server_response)

# This check is to determine if the response is a text response (xml or otherwise)
# so that we do not attempt to log bytes and other binary data.
if server_response.encoding:
if len(server_response.content) > 0 and server_response.encoding:
logger.debug(u'Server response from {0}:\n\t{1}'.format(
url, server_response.content.decode(server_response.encoding)))
return server_response

def _check_status(self, server_response):
logger.debug(self._safe_to_log(server_response))
if server_response.status_code >= 500:
raise InternalServerError(server_response)
elif server_response.status_code not in Success_codes:
Expand Down